You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If it's ok, I'd like to suggest the addition of whatever the maintainers have for their settings for formatting. I'm not sure if these are all correct or accurate to what other maintainers and developers have been using on this project, so please feel free to offer suggestions. I work on a few different projects on my machine with vscode and it'd be helpful if there were project specific settings for this project. Alternatively, we could .gitignoresettings.json and offer suggested settings for our contribution guide. I might suggest the following:
Ok, so, regarding the tab size, I can see that all the tabs in this project are 4 spaces, but 2 space tabs is consistent with most front end development I've seen.
Also, perhaps we could include the tab size, whether 2 or 4, in linting. Lastly in this, it might be a good opportunity to migrate to eslint.
Let me know if you have any other suggestions for this.
The text was updated successfully, but these errors were encountered:
I have no strong opinion on the code styles. As long as it makes the project setup easier, it's worth to do it. Thank you for the contribution and please go ahead.
If it's ok, I'd like to suggest the addition of whatever the maintainers have for their settings for formatting. I'm not sure if these are all correct or accurate to what other maintainers and developers have been using on this project, so please feel free to offer suggestions. I work on a few different projects on my machine with vscode and it'd be helpful if there were project specific settings for this project. Alternatively, we could
.gitignore
settings.json
and offer suggested settings for our contribution guide. I might suggest the following:Ok, so, regarding the tab size, I can see that all the tabs in this project are 4 spaces, but 2 space tabs is consistent with most front end development I've seen.
Also, perhaps we could include the tab size, whether 2 or 4, in linting. Lastly in this, it might be a good opportunity to migrate to eslint.
Let me know if you have any other suggestions for this.
The text was updated successfully, but these errors were encountered: