Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dom utilities. #5

Open
mseddon opened this issue Mar 14, 2016 · 2 comments
Open

Adding dom utilities. #5

mseddon opened this issue Mar 14, 2016 · 2 comments

Comments

@mseddon
Copy link

mseddon commented Mar 14, 2016

There are a couple of questions before I PR this that are probably worth checking.

  • Scala.js is currently at 0.6.5- scala-js-dom requires 0.6.7 currently. Is it okay to upgrade?
  • Are you certain you don't mind scala-js-dom as a dependency for this library?
@jducoeur
Copy link
Owner

The version upgrade is certainly fine (I should do that anyway), but the dependency question is a lot more interesting. I hadn't been thinking about that (still a bit early in the morning), and it's a good point: jsext is a bit more focused on extensions to the core, rather than the dom, and the elements so far don't imply that dependency.

Humph. Much though I'd like to just say, "yeah, sure", I suspect that's a compelling argument. We should probably have a similar-but-separate grab-bag library for dom-level stuff, so that, eg, RichFuture doesn't have dom dependencies...

@mseddon
Copy link
Author

mseddon commented Mar 14, 2016

Aha, glad I flagged that then. Perhaps adding a subproject for "org.querki" % "querki-jsext-dom" is the right way to go? Feel free to come up with a better name or method, I'm not precious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants