Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using JMP's built-in mpv.conf editor causes crash when calling script #834

Open
ftc2 opened this issue Jan 19, 2025 · 0 comments
Open

using JMP's built-in mpv.conf editor causes crash when calling script #834

ftc2 opened this issue Jan 19, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@ftc2
Copy link

ftc2 commented Jan 19, 2025

background

i learned about Ashyni's mpv dynamic-crop.lua from these GHIs:

#170
#517

seems to work well for automatically fixing issues associated with playback on ultrawide monitors (e.g. when letterbox is baked into the encode) instead of manually fiddling with JMP's built-in AR settings (accessible by clicking the gear during playback).

issue

the relevant mpv.conf line to import the script is script=/Users/user/Downloads/dynamic-crop.lua.

it works fine when you manually create a mpv.conf file in ~/Application Support/Jellyfin Media Player.

however, if you instead use JMP > Client Settings > Manual MPV Configuration (an in-app textbox you can put mpv.conf lines into), JMP crashes immediately at startup.

the Manual MPV Configuration lines are stored as other_conf in jellyfinmediaplayer.conf like this:

"sections": {
    "other": {
        "other_conf": "script=/Users/user/Downloads/dynamic-crop.lua"
    },
},

steps to reproduce

  • save a mpv script like dynamic-crop.lua somewhere on your fs
  • open JMP and go to Client Settings > Manual MPV Configuration
  • import the script using script=/path/to/dynamic-crop.lua
  • restart JMP
  • observe immediate crash

env

  • OS: macOS 15.2 arm64
  • JMP Version 1.11.1 arm64 app bundle downloaded from your github releases

logs

Jellyfin Media Player.log
crash report Jellyfin Media Player-2025-01-18-195916.ips.txt

@ftc2 ftc2 added the bug Something isn't working label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant