-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
142 jasmine node #145
Closed
Closed
142 jasmine node #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
edpe
approved these changes
Apr 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work and thanks for the explanation
🇳🇮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
Hello everyone! It has been some time. I took a little break from coding and decided to get back into it with something familiar that I am fond of e.g. dawn.
I haven't added any new features, or changed the overall architecture of the different modules.
This PR has the following changes:
module.exports = Gait
. This was necessary to use Jasmine's CLI. There are plenty of benefits to this but mainly it looks cooler and newer.require
in the browser. Browserify is much easier to set up than webpack, and we don't need anything too clever as this isn't a full stack app. Browserify should make future deployment much easier.All of the tests are passing and I've run the app and it appears to be working well!
So now you can do:
npm install
(as always) to install dependencies.npm test
to run tests. Green dots = passing! Otherwise it will list failures in the command line.npm run build
to bundle dependencies. This is necessary before you open dawn.html. Doing this was necessary in order to use modern modular patterns (e.g.module.exports = Gait
).open dawn.html
to run!Still to do, in future work:
exports default Gait
) and use Babel to transpile to ES5.I appreciate there is a lot of hectic-looking stuff here. Please don't hesitate to ask if you have questions and feedback is always always welcome!