Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

142 jasmine node #145

Closed
wants to merge 30 commits into from
Closed

142 jasmine node #145

wants to merge 30 commits into from

Conversation

rcvink
Copy link
Collaborator

@rcvink rcvink commented Apr 11, 2018

Closes #142

Hello everyone! It has been some time. I took a little break from coding and decided to get back into it with something familiar that I am fond of e.g. dawn.

I haven't added any new features, or changed the overall architecture of the different modules.

This PR has the following changes:

  • Added jasmine as a node module instead of using the standalone jasmine.
  • Updated all modules to a more modern pattern e.g. module.exports = Gait. This was necessary to use Jasmine's CLI. There are plenty of benefits to this but mainly it looks cooler and newer.
  • Installed browserify to bundle dependencies and permit use of require in the browser. Browserify is much easier to set up than webpack, and we don't need anything too clever as this isn't a full stack app. Browserify should make future deployment much easier.
  • Relocated the contents of dawn-jquery.js into dawn.js. dawn-jquery.js was relying on global variables existing at the top scope, which did not work with bundling dependencies.
  • Updated README with new instructions on getting started.
  • Removed standalone jasmine.

All of the tests are passing and I've run the app and it appears to be working well!

So now you can do:

  • npm install (as always) to install dependencies.
  • npm test to run tests. Green dots = passing! Otherwise it will list failures in the command line.
  • npm run build to bundle dependencies. This is necessary before you open dawn.html. Doing this was necessary in order to use modern modular patterns (e.g. module.exports = Gait).
  • open dawn.html to run!

Still to do, in future work:

  • update code to ES6 (e.g. exports default Gait) and use Babel to transpile to ES5.
  • finish extracting dependencies to specific modules in which they are required. Once this is done, deployment will be much much easier.

I appreciate there is a lot of hectic-looking stuff here. Please don't hesitate to ask if you have questions and feedback is always always welcome!

rcvink added 30 commits April 11, 2018 19:36
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
co-authored by jenniferemshepherd <[email protected]>, elliewem <[email protected]>, rcvink <[email protected]>, edpe <[email protected]>
Copy link
Collaborator

@edpe edpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work and thanks for the explanation
🇳🇮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use jasmine via the node module instead of standalone.
2 participants