Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create renderer in simulation.setup() #48

Open
rcvink opened this issue Mar 10, 2018 · 0 comments
Open

Create renderer in simulation.setup() #48

rcvink opened this issue Mar 10, 2018 · 0 comments
Assignees
@rcvink
Labels
post-freeze Nice, small features we can add without changing the code significantly. refactoring code is working but could benefit from refactoring or extraction

Comments

@rcvink
Copy link
Collaborator

rcvink commented Mar 10, 2018

I noticed we are executing the following line in our dawn.js:

decoratedRenderer.createRender(decoratedEngine.matterEngine());

Perhaps this is something we should do in the Simulation.setup() method? What do people think?
@rcvink rcvink added the post-freeze Nice, small features we can add without changing the code significantly. label Mar 11, 2018
@rcvink rcvink added the refactoring code is working but could benefit from refactoring or extraction label Mar 12, 2018
@rcvink rcvink self-assigned this Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcvink rcvink

Labels
post-freeze Nice, small features we can add without changing the code significantly. refactoring code is working but could benefit from refactoring or extraction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcvink