Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserved bit in 802.11n should be 1 (instead of 0) #23

Open
redfast00 opened this issue Aug 16, 2022 · 2 comments
Open

Reserved bit in 802.11n should be 1 (instead of 0) #23

redfast00 opened this issue Aug 16, 2022 · 2 comments

Comments

@redfast00
Copy link
Contributor

While doing my masters thesis, I came across the documentation for OpenOFDM. It states here (https://openofdm.readthedocs.io/en/latest/sig.html#fig-ht-sig) that the reserved bit should be 0, but according to the standard, it should be set to 1 (see 802.11n-2009 page 276). I could make a PR to fix this, but I don't know if there's any other place I should fix this in (the Verilog code maybe?)

Aside, I would really like to thank you for writing such clear documentation, it helped me a lot. Your blog post on the 802.11n CRC calculation in Python was also very useful, thank you!

@jhshi
Copy link
Owner

jhshi commented Aug 18, 2022

It's a reserved bit -- shouldn't matter if it's 0 or 1. Feel free to send a PR to fix it

@redfast00
Copy link
Contributor Author

This was fixed in #24, but was not deployed to https://openofdm.readthedocs.io/en/latest/sig.html yet. I thought Read the Docs would automatically do this, but I guess not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants