From a316a753309b75556a433195a81966d6af004bb5 Mon Sep 17 00:00:00 2001
From: Jonathan Jin <me@jonathanj.in>
Date: Sat, 11 Jan 2025 17:48:22 -0500
Subject: [PATCH] CI: make tests passing on all versions (inc. snapshot)
 non-optional

Keeping the per-version optionality is not worth it. Plus it will be good for us
to stay abreast of changes in snapshot.
---
 .github/workflows/test.yaml | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 390e3268..68001aca 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -14,14 +14,12 @@ jobs:
         emacs_version:
         - 29.3
         - release-snapshot
+        - snapshot
         kubectl_version:
         - v1.26.1
         - v1.25.6
         - v1.24.10
         - v1.23.12
-        include:
-        - emacs_version: snapshot
-          ignore_error: true
     env:
       EMACS_VERSION: ${{ matrix.emacs_version }}
     steps:
@@ -47,14 +45,12 @@ jobs:
         make compile
 
     - name: Run unit and static tests
-      continue-on-error: ${{ matrix.ignore_error != '' && matrix.ignore_error }}
       run: |
         make testall
 
     - name: Setup integration test cluster
       id: kind
       uses: helm/kind-action@v1.4.0
-      continue-on-error: ${{ matrix.ignore_error != '' && matrix.ignore_error }}
       with:
         config: tests/test-cluster.yaml
         cluster_name: kele-test-cluster0
@@ -63,15 +59,10 @@ jobs:
     # See #69
     - name: Try populating discovery cache
       id: discovery
-      if: steps.kind.outcome == 'success'
-      continue-on-error: ${{ matrix.ignore_error != '' && matrix.ignore_error }}
       run: |
         kubectl -v=10 cluster-info
 
     - name: Run integration tests
-      continue-on-error: ${{ matrix.ignore_error != '' && matrix.ignore_error }}
-      id: integration
-      if: steps.discovery.outcome == 'success'
       uses: nick-fields/retry@v2
       with:
         # at least one test is flaky. See #40
@@ -82,7 +73,6 @@ jobs:
           cask exec buttercup -L . tests/integration/
 
     - name: Upload coverage
-      if: steps.integration.outcome == 'success' && steps.integration.conclusion == 'success'
       uses: codecov/codecov-action@v4
       with:
         env_vars: EMACS_VERSION