From 2150bb44c41683cfa379a15ebc2e220afecb8679 Mon Sep 17 00:00:00 2001 From: Daniel Trierweiler Date: Mon, 12 Apr 2021 14:05:43 +0200 Subject: [PATCH 1/2] JVB HTTP servers should be configurable Those 4 new envs would enable the http server interface to be configured. This would be especially helpful in a kubernetes environment, where I use `hostNetwork: true` but I don't want the private http server to be exposed to the public. Default values would stay the same. Cheers. --- jvb/rootfs/defaults/jvb.conf | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/jvb/rootfs/defaults/jvb.conf b/jvb/rootfs/defaults/jvb.conf index 8ba26c414f..476956164d 100644 --- a/jvb/rootfs/defaults/jvb.conf +++ b/jvb/rootfs/defaults/jvb.conf @@ -45,11 +45,12 @@ videobridge { } http-servers { private { - host = 0.0.0.0 + host = "{{ .Env.JVB_HTTP_SERVER_PRIVATE_ADDRESS | default "0.0.0.0" }}" + port = "{{ .Env.JVB_HTTP_SERVER_PRIVATE_PORT | default "8080" }}" } public { - host = 0.0.0.0 - port = 9090 + host = "{{ .Env.JVB_HTTP_SERVER_PUBLIC_ADDRESS | default "0.0.0.0" }}" + port = "{{ .Env.JVB_HTTP_SERVER_PUBLIC_PORT | default "9090" }}" } } From bf2a9d903ba6f1340b44c5e094d45a214ce44e3c Mon Sep 17 00:00:00 2001 From: Daniel Trierweiler Date: Thu, 3 Jun 2021 10:37:44 +0200 Subject: [PATCH 2/2] Removed quotation marks --- jvb/rootfs/defaults/jvb.conf | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jvb/rootfs/defaults/jvb.conf b/jvb/rootfs/defaults/jvb.conf index 476956164d..09491a3780 100644 --- a/jvb/rootfs/defaults/jvb.conf +++ b/jvb/rootfs/defaults/jvb.conf @@ -45,12 +45,12 @@ videobridge { } http-servers { private { - host = "{{ .Env.JVB_HTTP_SERVER_PRIVATE_ADDRESS | default "0.0.0.0" }}" - port = "{{ .Env.JVB_HTTP_SERVER_PRIVATE_PORT | default "8080" }}" + host = {{ .Env.JVB_HTTP_SERVER_PRIVATE_ADDRESS | default "0.0.0.0" }} + port = {{ .Env.JVB_HTTP_SERVER_PRIVATE_PORT | default "8080" }} } public { - host = "{{ .Env.JVB_HTTP_SERVER_PUBLIC_ADDRESS | default "0.0.0.0" }}" - port = "{{ .Env.JVB_HTTP_SERVER_PUBLIC_PORT | default "9090" }}" + host = {{ .Env.JVB_HTTP_SERVER_PUBLIC_ADDRESS | default "0.0.0.0" }} + port = {{ .Env.JVB_HTTP_SERVER_PUBLIC_PORT | default "9090" }} } }