-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Web path prefix support #139
Comments
Could you provide more details about the use case ? If you are running multiple instances, I guess they each run on different ports ? So you need to run them behind a reverse proxy or something like that ? |
Yes, I need to run noVNC behind a reverse proxy. Specifically, I built my own image using docker-baseimage-gui, and then used noVNC and Web authentication ( For example:
Currently, if I enable WEB_AUTHENTICATION, it will be forced to jump to
But the login interface on the web page uses |
Ok, so yes, the way to go is to use the reverse proxy to server the interface of a container under a different path. You can check one of my container's documentation for an example of proxy configuration (e.g. https://github.com/jlesage/docker-crashplan-pro?tab=readme-ov-file#routing-based-on-url-path). The bug/problem, as you mentioned, is the login page that uses absolute path. This can be fixed. Is it working well without |
Yes, it works well after I modified the configuration:
I modified /rootfs/opt/noVNC/login/index.htm locally: <div id="loginStatus" class="alert alert-danger mb-4 d-none" role="alert">
</div>
- <form action="/login/login" method="post" id="loginForm" novalidate>
+ <form action="login" method="post" id="loginForm" novalidate>
<div class="form-floating mb-3"> Now it works fine when |
I found few other things that doesn't work well (fonts, logout, etc). I'm working on fixing these. |
Hey, just checking in—any idea when we might get the next release? 😊 |
Fixed in version 4.6.4. |
As the title says, if web prefixes are supported, multiple instances can be deployed on a single domain name without conflicts.
There is already a PR: #42, but it is too old to be merged into the current repository.
Is there any plan to support this feature or accept PR? Thank you!
The text was updated successfully, but these errors were encountered: