Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even if the underlying ansible process does not complete successfully, the ansible flow's run process does appear to exit successfully #1

Open
jfwood opened this issue Dec 17, 2015 · 0 comments

Comments

@jfwood
Copy link

jfwood commented Dec 17, 2015

Because ansible flow appears to exit successfully even on underlying ansible failures, processes that depend on this result (such as Jenkins jobs) will execute successfully leading to follow on jobs being invoked inappropriately.

Overall it seems the run process does not appear to return the exit code from the underlying ansible process. Digging in a bit, the run.py module invokes the venv.py module, but that ends up just doing a wait() on the Popen instance. Perhaps the returncode from Popen (per https://docs.python.org/2/library/subprocess.html#subprocess.Popen.returncode) should be returned from the Popen instance after wait() returns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant