You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because ansible flow appears to exit successfully even on underlying ansible failures, processes that depend on this result (such as Jenkins jobs) will execute successfully leading to follow on jobs being invoked inappropriately.
Overall it seems the run process does not appear to return the exit code from the underlying ansible process. Digging in a bit, the run.py module invokes the venv.py module, but that ends up just doing a wait() on the Popen instance. Perhaps the returncode from Popen (per https://docs.python.org/2/library/subprocess.html#subprocess.Popen.returncode) should be returned from the Popen instance after wait() returns?
The text was updated successfully, but these errors were encountered:
Because ansible flow appears to exit successfully even on underlying ansible failures, processes that depend on this result (such as Jenkins jobs) will execute successfully leading to follow on jobs being invoked inappropriately.
Overall it seems the run process does not appear to return the exit code from the underlying ansible process. Digging in a bit, the run.py module invokes the venv.py module, but that ends up just doing a wait() on the Popen instance. Perhaps the returncode from Popen (per https://docs.python.org/2/library/subprocess.html#subprocess.Popen.returncode) should be returned from the Popen instance after wait() returns?
The text was updated successfully, but these errors were encountered: