Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is API documentation? #72

Open
beigirad opened this issue Jul 8, 2021 · 16 comments
Open

Where is API documentation? #72

beigirad opened this issue Jul 8, 2021 · 16 comments
Labels
good first issue Good for newcomers

Comments

@beigirad
Copy link

beigirad commented Jul 8, 2021

I didn't find API document in website or in readme files.

Could you add mention them in readme files?

@sbabashahi
Copy link
Member

@beigirad did you mean something like https://api.jobguy.work/swagger/ ?

@beigirad
Copy link
Author

beigirad commented Jul 8, 2021

Yes. Thanks.

@beigirad beigirad closed this as completed Jul 8, 2021
@sbabashahi sbabashahi added the good first issue Good for newcomers label Jul 8, 2021
@sbabashahi
Copy link
Member

Could someone add link of swagger to read me file, it would be great to add description about using it.

@sbabashahi sbabashahi reopened this Jul 8, 2021
@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

hi.
what kinda description about usage you mean??

@sbabashahi
Copy link
Member

@lmn3x Like how to get token and use it for autorization

@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

got it, but, current api doesn't need authorization ,right?
i mean even after we get the token, there is no endpoint require token.

@sbabashahi
Copy link
Member

@lmn3x I think your answer is the difference between these 2 images:

Public:
Screenshot from 2021-07-12 15-27-12

Authorized:
Screenshot from 2021-07-12 15-30-32

Am I right?

@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

dammm..now i got the reason to do this 😆

@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

i have 2 question tho..

  1. English version is enough?
  2. it should be in separated file?
  3. should it include screenshots?? or just curl request and stuff?

@sbabashahi
Copy link
Member

There are 3 questions :))

  1. yes english is enough
  2. adding it to readme is fine
  3. try to add as details and descriptions as you can. think about it as someone has no clue and from here he/she wants to start.

@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

so should i add screenshots?

@sbabashahi
Copy link
Member

@lmn3x Sure

@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

@lmn3x I think your answer is the difference between these 2 images:

Public:
Screenshot from 2021-07-12 15-27-12

Authorized:
Screenshot from 2021-07-12 15-30-32

Am I right?

a normal user don't access to this, right?

@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

cuz after i authorize with token, i got the same public endpoints

@sbabashahi
Copy link
Member

@lmn3x yes, there are multi levels of Access

@lmn3x
Copy link
Contributor

lmn3x commented Jul 12, 2021

ok i got it..
this is my first github collaboration, sorry if i ask too many questions :)

@lmn3x lmn3x mentioned this issue Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants