From c20a12a29ef498fdf1fbb98cbb62fa8c19cd0152 Mon Sep 17 00:00:00 2001 From: tsantalis Date: Thu, 24 Oct 2024 05:57:52 -0400 Subject: [PATCH] Fix handling of Move Code refactoring for comments --- .../CommentTrackerChangeHistory.java | 17 ++--------- .../blame/blameTestWithLocalRepo14.txt | 30 +++++++++---------- .../blame/blameTestWithLocalRepo15.txt | 16 +++++----- .../blame/blameTestWithLocalRepo16.txt | 12 ++++---- 4 files changed, 32 insertions(+), 43 deletions(-) diff --git a/src/main/java/org/codetracker/CommentTrackerChangeHistory.java b/src/main/java/org/codetracker/CommentTrackerChangeHistory.java index e52ebdda84b..e7603d5181b 100644 --- a/src/main/java/org/codetracker/CommentTrackerChangeHistory.java +++ b/src/main/java/org/codetracker/CommentTrackerChangeHistory.java @@ -307,27 +307,16 @@ public boolean checkForExtractionOrInline(Version currentVersion, Version parent } } } - Comment commentBefore; - if (rightComment.getOperation().isPresent()) - commentBefore = Comment.of(rightComment.getComment(), rightComment.getOperation().get(), parentVersion); - else - commentBefore = Comment.of(rightComment.getComment(), rightComment.getClazz().get(), parentVersion); - if (matchedCommentFromSourceMethod == null) { - commentChangeHistory.handleAdd(commentBefore, rightComment, moveCodeRefactoring.toString()); - if(extractMatches == 0) { - elements.addFirst(commentBefore); - } - } - else { + if (matchedCommentFromSourceMethod != null) { VariableDeclarationContainer sourceOperation = moveCodeRefactoring.getSourceContainer(); Method sourceMethod = Method.of(sourceOperation, parentVersion); Comment leftComment = Comment.of(matchedCommentFromSourceMethod, sourceMethod); if(extractMatches == 0) { elements.addFirst(leftComment); } + commentChangeHistory.connectRelatedNodes(); + extractMatches++; } - commentChangeHistory.connectRelatedNodes(); - extractMatches++; } break; } diff --git a/src/test/resources/blame/blameTestWithLocalRepo14.txt b/src/test/resources/blame/blameTestWithLocalRepo14.txt index e2284a0a295..d5891a1ea26 100644 --- a/src/test/resources/blame/blameTestWithLocalRepo14.txt +++ b/src/test/resources/blame/blameTestWithLocalRepo14.txt @@ -64,17 +64,17 @@ ec752138b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispat 5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 64) LeaderElectionService leaderElectionService, ab8316f31 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-18 09:12:54 +0000 65) FatalErrorHandler fatalErrorHandler) throws IOException { 66) -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 67) super( -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 68) endpointConfiguration, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 69) leaderRetriever, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 70) clusterConfiguration, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 71) restConfiguration, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 72) resourceManagerRetriever, +0e3027d4b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-12-13 21:34:32 +0000 67) super( +0e3027d4b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-12-13 21:34:32 +0000 68) endpointConfiguration, +0e3027d4b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-12-13 21:34:32 +0000 69) leaderRetriever, +0e3027d4b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-12-13 21:34:32 +0000 70) clusterConfiguration, +0e3027d4b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-12-13 21:34:32 +0000 71) restConfiguration, +0e3027d4b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-12-13 21:34:32 +0000 72) resourceManagerRetriever, 5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 73) transientBlobService, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 74) executor, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 75) metricQueryServiceRetriever, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 76) leaderElectionService, -5f573804f flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-06 12:34:21 +0000 77) fatalErrorHandler); +0e3027d4b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-12-13 21:34:32 +0000 74) executor, +ac8225fd5 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (gyao 2018-01-26 12:50:25 +0000 75) metricQueryServiceRetriever, +ac8225fd5 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (gyao 2018-01-26 12:50:25 +0000 76) leaderElectionService, +ac8225fd5 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (gyao 2018-01-26 12:50:25 +0000 77) fatalErrorHandler); 78) ec752138b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2018-02-19 16:27:33 +0000 79) webSubmissionExtension = WebMonitorExtension.empty(); 6a62f1455 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-09-19 22:34:13 +0000 80) } @@ -87,11 +87,11 @@ ec752138b flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispat 87) c6243b8b1 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-09-21 07:30:50 +0000 88) final Time timeout = restConfiguration.getTimeout(); 89) -0a5aebb01 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-16 12:09:42 +0000 90) JobSubmitHandler jobSubmitHandler = new JobSubmitHandler( -0a5aebb01 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-16 12:09:42 +0000 91) restAddressFuture, -0a5aebb01 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-16 12:09:42 +0000 92) leaderRetriever, -0a5aebb01 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-16 12:09:42 +0000 93) timeout, -0a5aebb01 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-16 12:09:42 +0000 94) responseHeaders, +eddb5b0a4 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-11-07 14:07:41 +0000 90) JobSubmitHandler jobSubmitHandler = new JobSubmitHandler( +eddb5b0a4 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-11-07 14:07:41 +0000 91) restAddressFuture, +eddb5b0a4 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-11-07 14:07:41 +0000 92) leaderRetriever, +eddb5b0a4 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (Till Rohrmann 2017-11-07 14:07:41 +0000 93) timeout, +a25cd3fed flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-03 19:08:45 +0000 94) responseHeaders, 0a5aebb01 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-16 12:09:42 +0000 95) executor, 0a5aebb01 flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java (zentol 2018-07-16 12:09:42 +0000 96) clusterConfiguration); 97) diff --git a/src/test/resources/blame/blameTestWithLocalRepo15.txt b/src/test/resources/blame/blameTestWithLocalRepo15.txt index b2a9d7dfdbb..bd45822584a 100644 --- a/src/test/resources/blame/blameTestWithLocalRepo15.txt +++ b/src/test/resources/blame/blameTestWithLocalRepo15.txt @@ -371,10 +371,10 @@ bb91daf8e src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java ( bb91daf8e src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Kevin Cooney 2012-10-24 19:31:00 +0000 371) */ 078e45bd3 src/main/java/org/junit/internal/runners/BlockJUnit4ClassRunner.java (kbeck 2008-06-16 17:52:02 +0000 372) protected Statement withBefores(FrameworkMethod method, Object target, bb91daf8e src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Kevin Cooney 2012-10-24 19:31:00 +0000 373) Statement statement) { -123432f73 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (dsaff 2008-07-23 20:39:42 +0000 374) List befores = getTestClass().getAnnotatedMethods( -123432f73 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (dsaff 2008-07-23 20:39:42 +0000 375) Before.class); -198df01b7 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (David Saff 2009-05-12 03:29:36 +0000 376) return befores.isEmpty() ? statement : new RunBefores(statement, -198df01b7 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (David Saff 2009-05-12 03:29:36 +0000 377) befores, target); +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 374) List befores = getTestClass().getAnnotatedMethods( +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 375) Before.class); +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 376) return befores.isEmpty() ? statement : new RunBefores(statement, +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 377) befores, target); 078e45bd3 src/main/java/org/junit/internal/runners/BlockJUnit4ClassRunner.java (kbeck 2008-06-16 17:52:02 +0000 378) } 379) 7a3e99635 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (dsaff 2008-07-23 15:59:22 +0000 380) /** @@ -386,10 +386,10 @@ bb91daf8e src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java ( bb91daf8e src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Kevin Cooney 2012-10-24 19:31:00 +0000 386) */ 078e45bd3 src/main/java/org/junit/internal/runners/BlockJUnit4ClassRunner.java (kbeck 2008-06-16 17:52:02 +0000 387) protected Statement withAfters(FrameworkMethod method, Object target, bb91daf8e src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Kevin Cooney 2012-10-24 19:31:00 +0000 388) Statement statement) { -123432f73 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (dsaff 2008-07-23 20:39:42 +0000 389) List afters = getTestClass().getAnnotatedMethods( -123432f73 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (dsaff 2008-07-23 20:39:42 +0000 390) After.class); -198df01b7 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (David Saff 2009-05-12 03:29:36 +0000 391) return afters.isEmpty() ? statement : new RunAfters(statement, afters, -198df01b7 src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (David Saff 2009-05-12 03:29:36 +0000 392) target); +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 389) List afters = getTestClass().getAnnotatedMethods( +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 390) After.class); +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 391) return afters.isEmpty() ? statement : new RunAfters(statement, afters, +b5fb9c92d src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alistair A. Israel 2010-05-06 08:09:38 +0000 392) target); 078e45bd3 src/main/java/org/junit/internal/runners/BlockJUnit4ClassRunner.java (kbeck 2008-06-16 17:52:02 +0000 393) } 394) aad22b88b src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java (Alex Panchenko 2017-08-07 00:11:20 +0000 395) private Statement withRules(FrameworkMethod method, Object target, Statement statement) { diff --git a/src/test/resources/blame/blameTestWithLocalRepo16.txt b/src/test/resources/blame/blameTestWithLocalRepo16.txt index fa6afa2b025..836b311b499 100644 --- a/src/test/resources/blame/blameTestWithLocalRepo16.txt +++ b/src/test/resources/blame/blameTestWithLocalRepo16.txt @@ -158,12 +158,12 @@ abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 01:17:09 +0000 158) Util.threadFactory(Util.format("OkHttp %s Writer", hostname), false)); abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 01:17:09 +0000 159) if (builder.pingIntervalMillis != 0) { af6198a1e okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 23:37:34 +0000 160) writerExecutor.scheduleAtFixedRate(new PingRunnable(false, 0, 0), -af6198a1e okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 23:37:34 +0000 161) builder.pingIntervalMillis, builder.pingIntervalMillis, MILLISECONDS); +abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 01:17:09 +0000 161) builder.pingIntervalMillis, builder.pingIntervalMillis, MILLISECONDS); abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 01:17:09 +0000 162) } 163) c85153e6a okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Adrian Cole 2014-05-05 15:19:18 +0000 164) // Like newSingleThreadExecutor, except lazy creates the thread. -4b0c09eb6 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (Venil Noronha 2016-04-29 02:35:35 +0000 165) pushExecutor = new ThreadPoolExecutor(0, 1, 60, TimeUnit.SECONDS, -4b0c09eb6 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (Venil Noronha 2016-04-29 02:35:35 +0000 166) new LinkedBlockingQueue(), +712e56de2 okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Jesse Wilson 2014-10-11 14:11:44 +0000 165) pushExecutor = new ThreadPoolExecutor(0, 1, 60, TimeUnit.SECONDS, +c85153e6a okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Adrian Cole 2014-05-05 15:19:18 +0000 166) new LinkedBlockingQueue(), 4b0c09eb6 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (Venil Noronha 2016-04-29 02:35:35 +0000 167) Util.threadFactory(Util.format("OkHttp %s Push Observer", hostname), true)); 0c04821a2 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-07-09 21:19:04 +0000 168) peerSettings.set(Settings.INITIAL_WINDOW_SIZE, DEFAULT_INITIAL_WINDOW_SIZE); 0c04821a2 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-07-09 21:19:04 +0000 169) peerSettings.set(Settings.MAX_FRAME_SIZE, Http2.INITIAL_MAX_FRAME_SIZE); @@ -344,7 +344,7 @@ ea63463c2 src/main/java/libcore/net/spdy/SpdyConnection.java 358169b89 okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Adrian Cole 2014-01-27 05:54:25 +0000 344) void writeWindowUpdateLater(final int streamId, final long unacknowledgedBytesRead) { 91b1b671f okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-24 04:03:46 +0000 345) try { abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 01:17:09 +0000 346) writerExecutor.execute( -358169b89 okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Adrian Cole 2014-01-27 05:54:25 +0000 347) new NamedRunnable("OkHttp Window Update %s stream %d", hostname, streamId) { +abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 01:17:09 +0000 347) new NamedRunnable("OkHttp Window Update %s stream %d", hostname, streamId) { c4efcd93b src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Marcelo Cortes 2013-02-14 21:01:04 +0000 348) @Override public void execute() { d990b5819 okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Adrian Cole 2014-01-26 22:01:36 +0000 349) try { 3d43a8dba okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-07-09 22:09:19 +0000 350) writer.windowUpdate(streamId, unacknowledgedBytesRead); @@ -517,7 +517,7 @@ abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java 3d43a8dba okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-07-09 22:09:19 +0000 517) writer.windowUpdate(0, windowSize - Settings.DEFAULT_INITIAL_WINDOW_SIZE); 6171f5545 okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Jesse Wilson 2014-06-18 04:34:21 +0000 518) } 899693474 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-04-10 16:51:38 +0000 519) } -899693474 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-04-10 16:51:38 +0000 520) new Thread(readerRunnable).start(); // Not a daemon thread. +d4508141f okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (Adrian Cole 2014-01-26 19:48:15 +0000 520) new Thread(readerRunnable).start(); // Not a daemon thread. 21dc92f96 okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (jwilson 2013-08-11 16:02:54 +0000 521) } 522) c5f58e454 okhttp/src/main/java/com/squareup/okhttp/internal/framed/FramedConnection.java (jwilson 2015-12-02 17:44:41 +0000 523) /** Merges {@code settings} into this peer's settings and sends them to the remote peer. */ @@ -663,7 +663,7 @@ a91124b6d okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyC 663) a91124b6d okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (jwilson 2013-09-01 17:57:20 +0000 664) // Create a stream. 3d43a8dba okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-07-09 22:09:19 +0000 665) final Http2Stream newStream = new Http2Stream(streamId, Http2Connection.this, -3d43a8dba okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-07-09 22:09:19 +0000 666) false, inFinished, headerBlock); +0c04821a2 okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java (jwilson 2016-07-09 21:19:04 +0000 666) false, inFinished, headerBlock); 60d5852c6 src/main/java/com/squareup/okhttp/internal/net/spdy/SpdyConnection.java (jwilson 2012-12-31 07:35:27 +0000 667) lastGoodStreamId = streamId; a91124b6d okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java (jwilson 2013-09-01 17:57:20 +0000 668) streams.put(streamId, newStream); abb0a7908 okhttp/src/main/java/okhttp3/internal/http2/Http2Connection.java (Jesse Wilson 2018-02-22 01:17:09 +0000 669) listenerExecutor.execute(new NamedRunnable("OkHttp %s stream %d", hostname, streamId) {