Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo modal transitions #23

Closed
wants to merge 2 commits into from
Closed

Undo modal transitions #23

wants to merge 2 commits into from

Conversation

joeowenca
Copy link
Owner

Properly animate in and out the undo modal with CSS transitions

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-page ✅ Ready (Inspect) Visit Preview Oct 9, 2023 3:01am

@joeowenca
Copy link
Owner Author

The undo item is re-rendering quite a few times which is making it tricky to persist the 'show' state.

@joeowenca joeowenca linked an issue Oct 9, 2023 that may be closed by this pull request
@joeowenca joeowenca closed this Oct 14, 2023
@joeowenca joeowenca deleted the undo-modal-transitions branch October 14, 2023 05:11
@joeowenca
Copy link
Owner Author

Not merging this PR as too many changes have been made on other branches and the core functionality here needs to be reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo modal should fade in and out no matter what
1 participant