Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If mouse hovering over an undo modal, don't hide it until the mouse leaves #26

Open
joeowenca opened this issue Oct 9, 2023 · 2 comments · Fixed by #33
Open

If mouse hovering over an undo modal, don't hide it until the mouse leaves #26

joeowenca opened this issue Oct 9, 2023 · 2 comments · Fixed by #33
Labels
blocked Issues that are blocked by something else bonus enhancement New feature or request

Comments

@joeowenca
Copy link
Owner

If your mouse is hovering over an undo modal, the undo modal should stay as long as the mouse continues to hover it.

Once the 10000ms timer is up, the undo modal will stay while the mouse is hovering.

Once the mouse leaves, there can be an additional 1000ms delay to allow time for it to go or unintentional mouse-off movements.

@joeowenca joeowenca added the enhancement New feature or request label Oct 9, 2023
@joeowenca joeowenca linked a pull request Oct 14, 2023 that will close this issue
@joeowenca joeowenca added blocked Issues that are blocked by something else bonus labels Oct 15, 2023
@joeowenca
Copy link
Owner Author

Blocked as I am struggling to retain the elements getBoundingClientRect()'s position when the component re-renders. On mount, the 'elementPosition' state is set to 'undefined'. So therefore, each time the component re-renders, the position is lost.

@joeowenca
Copy link
Owner Author

re-opened as this only works if there is one undo item. Please refer to above comment for further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues that are blocked by something else bonus enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant