Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output should match input #32

Open
johnmackintosh opened this issue Jan 17, 2020 · 2 comments
Open

Output should match input #32

johnmackintosh opened this issue Jan 17, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@johnmackintosh
Copy link
Owner

Currently outputs a data.table
If dataframe or tibble is input, it's reasonable to expect the same format is returned.
Needs to import from tibble though, so need to check the weight of dependencies

@johnmackintosh johnmackintosh added the enhancement New feature or request label Jul 12, 2020
@johnmackintosh
Copy link
Owner Author

low priority - pending re-write of internals to allow for NSE

@johnmackintosh
Copy link
Owner Author

{collapse} has functions to quickly change between tibble/ data.frame/ data.table so reminder to investigate the logic and if necessary import those to help with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant