-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TYPO3 9 LTS #62
Comments
Dropped css_styled_content support
Marked eID is deprecated, added deprecation log and removed from inline TypoScript template respective MagnificpopupController
Use `renderStatic()` instead of `render()` in ViewHelpers
Re-written plugin and introduced a compatibility mode to stay compatible to templates/partials from extension version 1.x
Use jh-st-img to load images and added common css
type ajax is not deprecated anymore
Any plans on releasing a new version compatible with 9 LTS? The tasks seem to be finished... Regards |
There is an actual alpha https://github.com/jonathanheilmann/ext-jh_magnificpopup/releases/tag/2.0.0-alpha.2 but sadly not enough feedback for a final release. |
I tested the alpha and for me there are no problems but I only used the lightbox function for normal content |
Hey Jonathan! I´ve tested the 2.0.0-alpha.2 Version with Typo3 9.5.8. Unfortunately, the Lightbox isn´t working. Additionally, I get the following error message when adding new content elements with images: |
@jonathanheilmann alpha 2 is working well for me too with 9.5.8. I used it with regular image content elements and also for images rendered by a custom Extension inside a slider. @contechno : did you rebuild PHP Autoload Information in the install tool or composer dump-autoload? |
@jonnsn I did it via the install tool. |
I installed the extension as Plugin and tried to use it for displaying a video in the lightbox. I receive the following error message: Core: Exception handler (WEB): Uncaught TYPO3 Exception: Undeclared arguments passed to ViewHelper JonathanHeilmann\JhMagnificpopup\ViewHelpers\PageRenderer\AddJsInlineCodeViewHelper: name, addToFooter. Valid arguments are: | TYPO3Fluid\Fluid\Core\ViewHelper\Exception thrown in file /html/typo3/typo3_src-9.5.9/vendor/typo3fluid/fluid/src/Core/ViewHelper/AbstractViewHelper.php in line 476 I am using 9.5.9, bootstrap_package 11.0 and jh_magnicificpopup in the actual version on this github. |
renderStatic()
instead ofrender()
in ViewHelpersThe text was updated successfully, but these errors were encountered: