Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TYPO3 9 LTS #62

Open
9 tasks done
jonathanheilmann opened this issue Oct 18, 2018 · 7 comments
Open
9 tasks done

Support TYPO3 9 LTS #62

jonathanheilmann opened this issue Oct 18, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@jonathanheilmann
Copy link
Owner

jonathanheilmann commented Oct 18, 2018

  • Requires to drop TYPO3 7 LTS support
  • Drop css_styled_content support
  • Update ViewHelpers to use namespace TYPO3Fluid...
  • Migrate from TYPO3_DB
  • Mark eID as deprecated
  • Use renderStatic() instead of render() in ViewHelpers
  • Re-write plugin and introduce a compatibility mode to stay compatible to templates/partials from extension version 1.x
  • Use jh-st-img to load images and added common css
  • Update documentation
@jonathanheilmann jonathanheilmann self-assigned this Oct 18, 2018
@jonathanheilmann jonathanheilmann added this to the v2.0.0 milestone Dec 1, 2018
jonathanheilmann added a commit that referenced this issue Dec 1, 2018
Dropped TYPO3 7 LTS support
jonathanheilmann added a commit that referenced this issue Dec 1, 2018
Dropped css_styled_content support
jonathanheilmann added a commit that referenced this issue Dec 1, 2018
jonathanheilmann added a commit that referenced this issue Dec 1, 2018
jonathanheilmann added a commit that referenced this issue Dec 1, 2018
Marked eID is deprecated, added deprecation log and removed from inline TypoScript template respective MagnificpopupController
jonathanheilmann added a commit that referenced this issue Dec 1, 2018
Use `renderStatic()` instead of `render()` in ViewHelpers
jonathanheilmann added a commit that referenced this issue Dec 6, 2018
Re-written plugin and introduced a compatibility mode to stay compatible to templates/partials from extension version 1.x
jonathanheilmann added a commit that referenced this issue Dec 9, 2018
jonathanheilmann added a commit that referenced this issue Dec 9, 2018
Use jh-st-img to load images and added common css
jonathanheilmann added a commit that referenced this issue Dec 10, 2018
jonathanheilmann added a commit that referenced this issue Feb 28, 2019
type ajax is not deprecated anymore
@Tim-Obert
Copy link

Tim-Obert commented Apr 9, 2019

Any plans on releasing a new version compatible with 9 LTS? The tasks seem to be finished...

Regards

@jonathanheilmann
Copy link
Owner Author

There is an actual alpha https://github.com/jonathanheilmann/ext-jh_magnificpopup/releases/tag/2.0.0-alpha.2 but sadly not enough feedback for a final release.
It would be great if you could test the actual alpha and give some feedback about the used features and if there are any bugs. I do not expect any compatibility issues other than described here: https://github.com/jonathanheilmann/ext-jh_magnificpopup/blob/v2.0.0/Documentation/BreakingChanges/Version2000000/Index.rst

@Tim-Obert
Copy link

I tested the alpha and for me there are no problems but I only used the lightbox function for normal content

@contechno
Copy link

Hey Jonathan! I´ve tested the 2.0.0-alpha.2 Version with Typo3 9.5.8. Unfortunately, the Lightbox isn´t working. Additionally, I get the following error message when adding new content elements with images:
Class 'JonathanHeilmann\JhMagnificpopup\Hooks\UpdateColPosHook' not found

@jonnsn
Copy link

jonnsn commented Aug 21, 2019

@jonathanheilmann alpha 2 is working well for me too with 9.5.8. I used it with regular image content elements and also for images rendered by a custom Extension inside a slider.

@contechno : did you rebuild PHP Autoload Information in the install tool or composer dump-autoload?

@contechno
Copy link

contechno commented Aug 21, 2019

@jonnsn I did it via the install tool.
EDIT2: Now I figured out where the bug is: When normally adding an image-containing element, everything works fine. But when the image is added via the news-extension (tx_news) in a news-article, it doesn´t get the necessary class!

@hweckhardt
Copy link

I installed the extension as Plugin and tried to use it for displaying a video in the lightbox. I receive the following error message:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: Undeclared arguments passed to ViewHelper JonathanHeilmann\JhMagnificpopup\ViewHelpers\PageRenderer\AddJsInlineCodeViewHelper: name, addToFooter. Valid arguments are: | TYPO3Fluid\Fluid\Core\ViewHelper\Exception thrown in file /html/typo3/typo3_src-9.5.9/vendor/typo3fluid/fluid/src/Core/ViewHelper/AbstractViewHelper.php in line 476

I am using 9.5.9, bootstrap_package 11.0 and jh_magnicificpopup in the actual version on this github.

mbonaker added a commit to a7digital/ext-jh_magnificpopup that referenced this issue Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants