Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imageuid in MagnificpopupController.php to template var #65

Open
cmichael-de opened this issue Feb 24, 2019 · 6 comments
Open

Add imageuid in MagnificpopupController.php to template var #65

cmichael-de opened this issue Feb 24, 2019 · 6 comments
Assignees
Labels
Milestone

Comments

@cmichael-de
Copy link

In MagnificpopupController.php I added manually (and not update safe) a template var inside the renderLinktypeFile.

$viewAssign['imageuid'] = $file->getProperty('uid')

I use this uid to implement the inline frontend editing for image description inside the template:

<core:contentEditable table="sys_file_reference" field="description" uid="{imageuid}"> <figcaption>{imagecaption}</figcaption></core:contentEditable>

@cmichael-de
Copy link
Author

Is it possible for you to put it this var in the controller?

@jonathanheilmann
Copy link
Owner

jonathanheilmann commented Feb 28, 2019

Which TYPO3 version and extension version do you use?

I started working on version 2.0.0 of this extension, but struggled on finding users willing to test it, since there are going to be some breaking changes.

I'd like to ask you to test version 2.0.0-alpha.1, this version provides the complete file object in settings.mfpOptions.file and is used in Partials/Magnificpopup/Media/Figure.html.

Any feedback (especially to version 2.0.0) is appreciated!

@cmichael-de
Copy link
Author

I'am using TYPO3 8.7.22 and jh_magnificpopup 1.0.1. Here you can see it in action http://gsaitypo3.de.w0157f62.kasserver.com/projekte/ . If this is running with your 2.0.0 I can do the testing.

@jonathanheilmann
Copy link
Owner

Thanks. There will be an issue with version 2.0.0-alpha.1 in your case, thus I'm going to do some more work and update this issue when it's done.

@jonathanheilmann jonathanheilmann added this to the v2.0.0 milestone Feb 28, 2019
@jonathanheilmann jonathanheilmann self-assigned this Feb 28, 2019
@cmichael-de
Copy link
Author

Sounds good! I can test it tomorrow evening.

@jonathanheilmann
Copy link
Owner

I've updated the extension and release version 2.0.0-alpha.2.
It would be great if you could do some tests. If something fails after updating it would be interesting if it's working again if you enable the compatibility Mode.

Compatibility mode
As the templates has been reworked, there may be some breaking changes with your custom template adaptions. To make your life easier, there is a compatibility mode, which will activate the old processing of data before passing them to the template. Also the old paths will be used.

To enable compatibility mode set plugin.tx_jhmagnificpopup.compatibilityMode in Constant Editor category PLUGIN.TX_JHMAGNIFICPOPUP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants