Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails not resizing #35

Open
LlGC-szw opened this issue Jul 20, 2018 · 8 comments
Open

Thumbnails not resizing #35

LlGC-szw opened this issue Jul 20, 2018 · 8 comments

Comments

@LlGC-szw
Copy link

Just installed the latest version on TYPO3 7.6.29 and the images aren't resizing for the thumbnails (multi thumbnail view).

Tried setting 'Max width of preview' to 60px but that has no effect either.

@jonathanheilmann
Copy link
Owner

Did you set 'Max width of preview' to 60px or 60?
Actually 60px won’t work as an integer is expected, but is not validated as one. This is a bug, indeed.

@LlGC-szw
Copy link
Author

I have tried both 60 and 60px in 'Max width of preview' and 'Max height of preview' fields, neither affect the thumbnails displayed.

@jonathanheilmann
Copy link
Owner

Do you have a non-working example I may have a look at?

@LlGC-szw
Copy link
Author

I've added a few images and some caption text into https://www.library.wales/index.php?id=6813

The settings are:
Max width of preview = 60
Columns =3

Can't change the default css using TS either but I'll log that as a separate bug.

@jonathanheilmann
Copy link
Owner

Thanks for this example, I’m going to have a deep look at this on next monday.

@LlGC-szw
Copy link
Author

Thank you. Happy to test anything on our dev server and give you feedback. I'll also add the TS problem I've found.

@jonathanheilmann
Copy link
Owner

I've done some (larger) investigations at this issue and maybe there is a simple solution:
It looks like jh_photoswipe does not work with image layout key srcset as used in your case.
A workaround could be this singe TypoScript Setup line:

lib.tx_jhphotoswipe.multiThumbnail.cssStyledContent.1.layoutKey = default

Another solution would be, to copy your local sourceCollection into jh_photoswipe´s sourceCollection lib.tx_jhphotoswipe.multiThumbnail.cssStyledContent.1.sourceCollection

@LlGC-szw
Copy link
Author

We haven't specified the image layout in our template, only for specific bespoke extensions we've created. For all other extensions, images are as the extension or default TYPO3 settings dictate. As you can see images for all breakpoints are the same with no alternative source specified:

I've added the TS to the setup file and there seems to be no difference in thumbnail generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants