-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This document requires 'TrustedHTML' assignment #38
Comments
Good catch! That TrustedHTML patch was never added to the boilerplate repo. It would probably be very useful and instructive if added! Do you think you could be able to create a PR for that? I'm kinda busy with family vacation atm and while I can quickly approve a PR, implementing it myself might take a bit more time 😇 |
I will try. This level of JS, Build, Distribution, etc.. is new to me. If
I have sometime tonight I will look. Enjoy your vacay!
…On Tue, Jul 16, 2024 at 12:06 PM Jostein Kjønigsen ***@***.***> wrote:
Good catch! That TrustedHTML patch was never added to the boilerplate repo.
It would probably be very useful and instructive if added!
Do you think you could be able to create a PR for that?
I'm kinda busy with family vacation atm and while I can quickly approve a
PR, implementing it myself might take a bit more time 😇
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVPODJ3WGSXI7T5GAHNC4LZMVVMDAVCNFSM6AAAAABK64PQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGY2DAOBWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Can you point me to the particular pull request from the gmailjs repo where the TrustedHTML updates were implemented? This would help get me started in updating the boilerplate to remedy the issues with it. |
It looks like the boilerplate is attempting to solved the trusted html policy issue, but I guess not working correctly?
|
I see where you fixed the boiler plate: KartikTalwar/gmail.js#779 (comment) UPDATE! |
Oh my bad then. Well, the good news is you got things working, I guess? |
Yes/No. Boilerplate working, yes! Now working on my custom
implementation. Unfortunately over the past few years I've lost my
original Gmail code that helped me manage and reply to emails in my Inbox.
As I'm replying to you, I'm thinking through some of the features I had
(this is a thought exercise):
1. From a popup - Implemented Reply button click
2. Inject custom template into compose window
3. Update Subject of email
4. By changing the subject and including myself in the reply, this
*custom* subject can then trigger a filter which can then run any of the
filter routines that you have defined. For instance, applying a Label to
the email.
1. Applying a label to the email was a challenge I had posed to the
Gmail group in the past. I don't believe we ever figured that out.
5. I was also looking up customer details by calling my Api in the
background script by Ajax calls
FYI - was in Oslo this past May. I should have looked you up!
Karl Stubsjoen
(602) 845-0006
…On Tue, Aug 13, 2024 at 11:33 PM Jostein Kjønigsen ***@***.***> wrote:
Oh my bad then.
Well, the good news is you got things working, I guess?
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVPODKI6TO5WHQ34ZJJOMDZRL22PAVCNFSM6AAAAABK64PQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBXHE2TSNJZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
If your extension was published anywhere, it should be easy to just redownload the ZIP/XPI and extract the old code, right? ;) |
It might be on a thumb drive somewhere. It has been awhile since I've
tried to resurrect it. I'm still looking for it!
Karl Stubsjoen
(602) 845-0006
…On Wed, Aug 14, 2024 at 11:12 AM Jostein Kjønigsen ***@***.***> wrote:
If your extension was published anywhere, it should be easy to just
redownload the ZIP/XPI and extract the old code, right? ;)
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVPODPB43AHSLYHIRWV35LZROM2PAVCNFSM6AAAAABK64PQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGUYTANJYHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hey Karl, Do you have that custom extension, I want to integrate this with my screens and all. |
Hey Kmax,
Unfortunately, I haven't been able to locate that thumb drive.
Regarding the boilerplate issue and the TrustedHTML concern, I believe
those were resolved. The problem I encountered seems to have been caused by
a different extension, not the boilerplate itself.
Specifically, which custom extension, or which features were you interested
in?
Best,
Karl
Karl Stubsjoen
(602) 845-0006
…On Thu, Nov 21, 2024 at 9:44 AM Kmax ***@***.***> wrote:
Hey Karl,
Do you have that custom extension, I want to integrate this with my
screens and all.
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVPODLBU4HKPY5OE6NL4ND2BYEXXAVCNFSM6AAAAABK64PQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJRG42DONBUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Oh, I was looking for a good example where I could inject my custom pop-up as a button. |
To be clear... the boilerplate works fine for me. When you say "stopped working", are you talking about the boiler-plate or the project you yourself built? |
The project that I built based on the older boiler plate broke because Gmail changed a bunch of stuff. |
Can I inject jquery, my legacy requires it. |
I'm including jquery, but bundling it. Once loaded, it should be easy to inject into the global DOM if you need it. |
I'm following the ReadMe installation instructions for installing the boilerplate. I've ran the npm install and build steps and have loaded the extension into chrome. I've attached my console log.
mail.google.com-1721145048368.log
In this log, I see errors related to TrustedHTML and see errors related to jQuery is not defined. There are more errors, but these might be a cascading result stemming from the above. I'm not sure.
Is the boilerplate outfitted with the jQuery updates that fix this TrustedHTML issue?
Karl..
The text was updated successfully, but these errors were encountered: