Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MapLibre cocoapods dependency #163

Closed
Tracked by #26
josxha opened this issue Dec 5, 2024 · 1 comment · May be fixed by #169
Closed
Tracked by #26

Add MapLibre cocoapods dependency #163

josxha opened this issue Dec 5, 2024 · 1 comment · May be fixed by #169
Assignees
Labels
ios iOS specific issue
Milestone

Comments

@josxha
Copy link
Owner

josxha commented Dec 5, 2024

One of the design ideas maplibre followed was to have all in one package to simplify development, ci and releases. Unfortunally, the MapLibre cocoapods dependency has the same name as this package and podspec module_name is not supported. Related issue:

It is currently unknown if the problem persists with the swift package manager.

Federated Plugin

One option would be to migrate the package into a full federated plugin.

Minimal iOS Package

An alternative to a full federated plugin could be to just separate the ios ffi code and keep the rest in the maplibre package.

@josxha josxha mentioned this issue Dec 5, 2024
17 tasks
@josxha josxha added the ios iOS specific issue label Dec 5, 2024
@josxha josxha self-assigned this Dec 5, 2024
@josxha josxha changed the title Convert the package into a federated plugin Add MapLibre iOS dependency Dec 5, 2024
@josxha josxha changed the title Add MapLibre iOS dependency Add MapLibre cocoapod dependency Dec 5, 2024
@josxha josxha added this to the iOS milestone Dec 5, 2024
@josxha josxha changed the title Add MapLibre cocoapod dependency Add MapLibre cocoapods dependency Dec 5, 2024
@josxha josxha linked a pull request Dec 7, 2024 that will close this issue
@josxha
Copy link
Owner Author

josxha commented Dec 7, 2024

I decided to create a minimal package that contains the native MapLibre iOS SDK and swift implementation. The core package will no longer have a iOS part itself but rely on maplibre_ios.

@josxha josxha closed this as completed Dec 7, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in maplibre dev Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ios iOS specific issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant