TypeError: Failed to construct 'Response': Response with null body status cannot have body

[djherbis]

TypeError: Failed to construct 'Response': Response with null body status cannot have body

xhook/src/xhook.coffee

Line 561 in 8b9b595

response = new Response(userResponse.body or userResponse.text, userResponse)

Some status codes (ex. 204) require having no body set (null/undefined), however this statement falls back to what I believe is an empty string if no body is returned, causing the constructor call to fail and making it impossible to properly respond to these.

[djherbis]

A null body status is a status that is 101, 204, 205, or 304.

Ref: https://fetch.spec.whatwg.org/#statuses

[djherbis]

@jpillora I think this is a fairly tiny fix, would you be able to fix it or if I contribute a PR would you be able to do a release that includes it?

It should basically just be making sure we pass a null or undefined body to the Response constructor if the status is any of the given codes.

[cchamberlain]

This issue is causing runtime errors in our project so I forked xhook and made the necessary fixes and submitted PR. We will be pointing to the fork until this change is merged / published.

[jpillora]

See pinned issue at the top https://github.com/jpillora/xhook/issues

…

On Sat, 7 Nov 2020 at 9:57 am Cole Chamberlain ***@***.***> wrote: This issue is causing runtime errors in our project so I forked xhook and made the necessary fixes and submitted PR. We will be pointing to the fork until this change is merged / published. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2X4ZDYVPXMYD65MWDKMTSOR5PNANCNFSM4RNURYXQ> .