Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set arrangement rules based on DeclarationOrder check in CheckStyleCodeStyleImporter #623

Open
joao-martins-tdx opened this issue Oct 16, 2023 · 3 comments
Labels
code-style-importer Related to the code style import functionality

Comments

@joao-martins-tdx
Copy link

CheckStyleCodeStyleImporter doesn't seem to set the arrangement rules based on the DeclarationOrder check. It would be great if it did in order to prevent checkstyle errors when rearranging code.

@jshiell
Copy link
Owner

jshiell commented Oct 22, 2023

Thanks for the report. To be completely honest, it's not high on my priority list - the code style importer was a contribution, and the contributer has never contributed any fixes. But never say never.

@nrayburn-tech
Copy link

@jshiell would you happen to know how to apply the arrangement settings when importing? I implemented what I thought would work, but it doesn’t seem to change what the code style has from my manual testing.
https://github.com/nrayburn-tech/checkstyle-idea/blob/272c6a6634340a0621aaae47da4dc477063d0908/src/main/java/org/infernus/idea/checkstyle/importer/modules/DeclarationOrderImporter.java#L86

Once I get that figured out, I can submit a PR for this.

@jshiell
Copy link
Owner

jshiell commented Aug 24, 2024

@nrayburn-tech sorry, I fear I'm little help here. As said, it was a contribution so my only exposure to this particular API has been as bug fixes for this particular feature!

@jshiell jshiell added the code-style-importer Related to the code style import functionality label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-style-importer Related to the code style import functionality
Projects
None yet
Development

No branches or pull requests

3 participants