Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Scheme does not work well for google_checks since 10.19.0 #657

Open
vbezhenar opened this issue Dec 2, 2024 · 1 comment
Open

Comments

@vbezhenar
Copy link

I'm using Idea 2023.3.8 and CheckStyle-IDEA 5.99.0.

I've downloaded file google_checks.xml 10.20.2.

I've imported it into Idea Code Style using Import Scheme / CheckStyle Configuration.

Here's formatted Java code which obviously does not correspond to the Google style:

package test;

public class Test
{
  public static void main(String[] args)
  {
    System.out.println("Hello, world");
  }
}

Last working file was google_checks.xml 10.18.2.

Here's the same code formatted using this file imported:

package test;

public class Test {
  public static void main(String[] args) {
    System.out.println("Hello, world");
  }
}

This is correct output.

I did some experiments and found out that this commit: 5b301c7a47febfacb78c9d1dd48f99d7a2733310 Issue 15324: added support to check for preceding line break of lcurly for switch-case-default blocks was the first which "broke" the import functionality. The commit before (ee37567e7b96f4e385868b77f11d63a213718b35) works well.

@jshiell
Copy link
Owner

jshiell commented Dec 8, 2024

Thanks for the report. The import functionality was a contribution and has been unmaintained for some time, so to be completely honest it's not high on my priority list. But never say never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants