Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming: formatting of type variables #49

Open
wmdietl opened this issue Dec 14, 2023 · 1 comment
Open

Upstreaming: formatting of type variables #49

wmdietl opened this issue Dec 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wmdietl
Copy link
Collaborator

wmdietl commented Dec 14, 2023

Changes from

  • 5fc6c28
  • and handling of verbose generics (didn't track down commit that removed that code, yet).
@cpovirk
Copy link
Collaborator

cpovirk commented Dec 19, 2023

Is the "handling of verbose generics" you're referring to the fact that we output Foo<Bar?> and similar? If so, that's handled on the checker side by providing our own AnnotatedTypeFormatter.

I... don't know if 5fc6c28 is serving a purpose at this point or not. Maybe it matters in the debugger, but I kind of doubt that it even does there. If we're lucky, we don't need any upstream changes for this.

@wmdietl wmdietl added the enhancement New feature or request label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants