Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Github (Light/Dark) Mode Attribute for JSR #874

Open
benemmaofficial opened this issue Dec 20, 2024 · 1 comment
Open

Expose Github (Light/Dark) Mode Attribute for JSR #874

benemmaofficial opened this issue Dec 20, 2024 · 1 comment

Comments

@benemmaofficial
Copy link

JSR doesn't have a dark/light mode attribute like GitHub does. This discrepancy seems to be causing some issues with our packages that have a multi-theme system on JSR

Screenshot 2024-12-13 at 14-18-35 @inspatial_util - JSR
@github-project-automation github-project-automation bot moved this to Needs Triage in JSR Dec 20, 2024
@jackcarey
Copy link

The repo in the screenshot uses the URL fragment #gh-light-mode-only and #gh-dark-mode-only, which GitHub no longer prefers. They enabled the picture HTML element in their markdown: https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
JSR
Status: Needs Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackcarey @benemmaofficial