Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate @API to a stand-alone module #436

Closed
8 tasks done
sbrannen opened this issue Jul 25, 2016 · 4 comments
Closed
8 tasks done

Relocate @API to a stand-alone module #436

sbrannen opened this issue Jul 25, 2016 · 4 comments

Comments

@sbrannen
Copy link
Member

sbrannen commented Jul 25, 2016

Overview

The @API annotation may better serve the community at large if it is moved from junit-platform-commons to a stand-alone module.

Related Issues

Deliverables

  • Refactor the @API annotation so that it has the following attributes:
    • status: Status (used to be value)
    • since: String (version the status was last changed, e.g. "5.0.0", defaults to "")
    • consumers: String[] (list of package patterns for intended consumers, defaults to {"*"})
  • Rename Status constants to align with industry standards for enum constants.
  • Set since attribute across the JUnit 5 code base.
  • ❌ Set consumers attribute across the JUnit 5 code base.
  • Move @API to a stand-alone project on GitHub.
  • Use @API from the @API Guardian project and delete @API from junit-platform-commons.
@sbrannen
Copy link
Member Author

sbrannen commented May 7, 2017

Currently slated for 5.0 M5 in order to be discussed amongst the team.

@marcphilipp marcphilipp modified the milestones: 5.0 M6, 5.0 M5 May 10, 2017
@marcphilipp marcphilipp modified the milestones: 5.0 M6, 5.0 RC1 Jul 18, 2017
@sbrannen sbrannen changed the title Consider relocating @API to a stand-alone module Relocate @API to a stand-alone module Jul 26, 2017
@sbrannen sbrannen modified the milestones: 5.0 RC1, 5.0 GA Jul 29, 2017
@marcphilipp
Copy link
Member

The new @API annotation will have the following attributes:

  • status: Status (used to be value)
  • since: String (version the status was last changed, e.g. "5.0.0", defaults to "")
  • consumers: String[] (list of package patterns for intended consumers, defaults to {"*"})

sbrannen added a commit that referenced this issue Sep 8, 2017
This commit introduces the following changes in the API of the @API
annotation in preparation for moving @API to an external, stand-alone
project.

- `Usage` enum renamed to `Status`
- all enum constants in `Status` renamed to follow industry standards
- `value` attribute renamed to `status`
- new `since` attribute
- new `consumers` attribute

Issue: #436
sbrannen pushed a commit that referenced this issue Sep 8, 2017
sbrannen added a commit that referenced this issue Sep 8, 2017
sbrannen pushed a commit that referenced this issue Sep 8, 2017
@sbrannen
Copy link
Member Author

sbrannen commented Sep 8, 2017

Update: @API has been moved to the following new repository.

https://github.com/apiguardian-team/apiguardian

Note, however, that artifacts are currently not published.

sbrannen pushed a commit that referenced this issue Sep 9, 2017
This commit removes the @API annotation from the junit-platform-commons
project in favor of the @API annotation from the the @API Guardian
project.

Issue: #436
sbrannen pushed a commit that referenced this issue Sep 9, 2017
sbrannen added a commit that referenced this issue Sep 9, 2017
This commit changes the link to the @API documentation to point to its
soon-to-be new home (i.e., in the "current" folder which does not yet
exist on the @API Guardian documentation Web site).

Issue: #436
@sbrannen
Copy link
Member Author

sbrannen commented Sep 9, 2017

All @API related tasks have now been completed in preparation for 5.0 GA.

@sbrannen sbrannen closed this as completed Sep 9, 2017
@ghost ghost removed the status: in progress label Sep 9, 2017
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
This commit introduces the following changes in the API of the @API
annotation in preparation for moving @API to an external, stand-alone
project.

- `Usage` enum renamed to `Status`
- all enum constants in `Status` renamed to follow industry standards
- `value` attribute renamed to `status`
- new `since` attribute
- new `consumers` attribute

Issue: junit-team#436
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
This commit removes the @API annotation from the junit-platform-commons
project in favor of the @API annotation from the the @API Guardian
project.

Issue: junit-team#436
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
This commit changes the link to the @API documentation to point to its
soon-to-be new home (i.e., in the "current" folder which does not yet
exist on the @API Guardian documentation Web site).

Issue: junit-team#436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants