Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockerSpawner breaks the Spawner options_form API #524

Open
akhmerov opened this issue Dec 24, 2024 · 0 comments · May be fixed by #525
Open

DockerSpawner breaks the Spawner options_form API #524

akhmerov opened this issue Dec 24, 2024 · 0 comments · May be fixed by #525
Labels
bug

Comments

@akhmerov
Copy link

Bug description

jupyterhub.spawner.Spawner defines options_from_form as a Callable traitlet. dockerspawner.DockerSpawner instead defines options_from_form as a method. This prevents overriding options_from_form without subclassing. Is there a reason for this change?

I arrive here from investigating a related question: https://discourse.jupyter.org/t/more-love-to-spawner-options-form/31126?u=anton_akhmerov
@akhmerov akhmerov added the bug label Dec 24, 2024
@akhmerov akhmerov changed the title DockerSpawner breaks the Spawner API DockerSpawner breaks the Spawner options_form API Dec 24, 2024
@akhmerov akhmerov linked a pull request Dec 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert options_from_form into traitlet akhmerov/dockerspawner
1 participant
@akhmerov