Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): Add currency as dimension and filter for disputes #7006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(analytics): Add currency as dimension and filter for disputes #7006

wants to merge 1 commit into from

Conversation

tsdk02
Copy link
Contributor

@tsdk02 tsdk02 commented Jan 8, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added currency as dimension and filter for disputes, required for Analytics V2 Dashboard.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

For better filtering related analytics

How did you test it?

Hit the curl:

curl --location 'http://localhost:8080/analytics/v1/org/metrics/disputes' \
--header 'Accept: */*' \
--header 'Accept-Language: en-US,en;q=0.9' \
--header 'Connection: keep-alive' \
--header 'Content-Type: application/json' \
--header 'Origin: http://localhost:9000' \
--header 'QueryType: Chart' \
--header 'Referer: http://localhost:9000/' \
--header 'Sec-Fetch-Dest: empty' \
--header 'Sec-Fetch-Mode: cors' \
--header 'Sec-Fetch-Site: same-site' \
--header 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36' \
--header 'api-key: dev_ssyiqBXK7Ou1HUQuH0Z80BsHuV5pojc0uWli4QbNXGM1f4pn7jCIyb9VFiHlyATQ' \
--header 'sec-ch-ua: "Google Chrome";v="129", "Not=A?Brand";v="8", "Chromium";v="129"' \
--header 'authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiNmNkZTA0NzYtMTFlMi00NGE5LTlkMjUtOTA5M2QzNDQwZjhlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzM1MDQxMjkzIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTczNjM2MDQ5Mywib3JnX2lkIjoib3JnX2pwanI5TkFEWlhqSENNYTU5MmF3IiwicHJvZmlsZV9pZCI6InByb19QRHUydVA3aWNuM2lXY0I3V0VVSSIsInRlbmFudF9pZCI6InB1YmxpYyJ9.tCy_qvwHxdPO1yor-A6IpZKVpC8uWxFGOgMvS35tRJ4' \
--header 'sec-ch-ua-mobile: ?0' \
--header 'sec-ch-ua-platform: "macOS"' \
--data '[
    {
        "timeRange": {
            "startTime": "2024-10-16T18:30:00Z",
            "endTime": "2024-10-24T12:09:00Z"
        },
        "timeSeries": {
            "granularity": "G_ONEDAY"
        },
        "filters": {
            "currency": ["USD"]
        },
        "mode": "ORDER",
        "source": "BATCH",
        "metrics": [
            "dispute_status_metric"
        ]
    }
]'

image
Currency filter is now getting added in the query while trying to get the data to calculate the metrics.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@tsdk02 tsdk02 added C-feature Category: Feature request or enhancement A-Analytics labels Jan 8, 2025
@tsdk02 tsdk02 self-assigned this Jan 8, 2025
@tsdk02 tsdk02 requested a review from a team as a code owner January 8, 2025 05:53
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 8, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/analytics/src/disputes/filters.rs  70% smaller
  crates/api_models/src/analytics/disputes.rs  1% smaller
  crates/analytics/src/disputes/core.rs  0% smaller
  crates/analytics/src/disputes/metrics.rs  0% smaller
  crates/analytics/src/disputes/metrics/dispute_status_metric.rs  0% smaller
  crates/analytics/src/disputes/metrics/sessionized_metrics/dispute_status_metric.rs  0% smaller
  crates/analytics/src/disputes/metrics/sessionized_metrics/total_amount_disputed.rs  0% smaller
  crates/analytics/src/disputes/metrics/sessionized_metrics/total_dispute_lost_amount.rs  0% smaller
  crates/analytics/src/disputes/metrics/total_amount_disputed.rs  0% smaller
  crates/analytics/src/disputes/metrics/total_dispute_lost_amount.rs  0% smaller
  crates/analytics/src/disputes/types.rs  0% smaller
  crates/analytics/src/sqlx.rs  0% smaller

@tsdk02 tsdk02 linked an issue Jan 8, 2025 that may be closed by this pull request
feat(analytics): Add currency as dimension and filter for disputes #7005
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisIsMani ThisIsMani Awaiting requested review from ThisIsMani

@ShivanshMathurJuspay ShivanshMathurJuspay Awaiting requested review from ShivanshMathurJuspay

At least 2 approving reviews are required to merge this pull request.

Assignees

@tsdk02 tsdk02

Labels
A-Analytics C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(analytics): Add currency as dimension and filter for disputes
1 participant
@tsdk02