Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address Rust 1.84.0 clippy lints #7021

Merged
merged 2 commits into from
Jan 15, 2025
Merged

chore: address Rust 1.84.0 clippy lints #7021

merged 2 commits into from
Jan 15, 2025

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Jan 10, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR addresses the clippy lints occurring due to new rust version 1.84.0
Majorly addresses unnecessary_map_or clippy lint - https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

CI checks should pass as this PR addresses clippy lints.

  1. ran just clippy with new rust version (1.84.0)

image

  1. ran just clippy_v2 with new rust version (1.84.0)

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Chethan-rao Chethan-rao added the C-refactor Category: Refactor label Jan 10, 2025
@Chethan-rao Chethan-rao self-assigned this Jan 10, 2025
@Chethan-rao Chethan-rao requested review from a team as code owners January 10, 2025 09:59
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 10, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/authorizedotnet/transformers.rs  99% smaller
  crates/diesel_models/src/query/address.rs  96% smaller
  crates/router/src/connector/cybersource/transformers.rs  92% smaller
  crates/router/src/db/dashboard_metadata.rs  87% smaller
  crates/router/src/connector/utils.rs  78% smaller
  crates/hyperswitch_connectors/src/utils.rs  76% smaller
  crates/router/src/connector/bankofamerica/transformers.rs  69% smaller
  crates/router/src/connector/wellsfargo/transformers.rs  68% smaller
  crates/router/src/core/admin.rs  60% smaller
  crates/euclid/src/backend/vir_interpreter/types.rs  59% smaller
  crates/router/src/core/utils.rs  31% smaller
  crates/router/src/core/relay/utils.rs  30% smaller
  crates/router/src/core/payment_methods/cards.rs  28% smaller
  crates/router/src/core/refunds.rs  25% smaller
  crates/router/src/core/fraud_check.rs  25% smaller
  crates/router/src/core/payouts/helpers.rs  18% smaller
  crates/router/src/services/pm_auth.rs  17% smaller
  crates/router/src/services/authentication/blacklist.rs  17% smaller
  crates/router/src/core/fraud_check/flows/sale_flow.rs  16% smaller
  crates/router/src/core/fraud_check/flows/checkout_flow.rs  15% smaller
  crates/router/src/core/fraud_check/flows/transaction_flow.rs  15% smaller
  crates/router/src/core/fraud_check/flows/record_return.rs  15% smaller
  crates/storage_impl/src/redis/kv_store.rs  13% smaller
  crates/router/src/db/refund.rs  12% smaller
  crates/euclid/src/dssa/graph.rs  12% smaller
  crates/router/src/core/payments/operations/payment_create.rs  12% smaller
  crates/router/src/utils/user/dashboard_metadata.rs  12% smaller
  crates/router/src/connector/noon/transformers.rs  12% smaller
  Cargo.lock Unsupported file format
  crates/euclid_wasm/Cargo.toml Unsupported file format
  crates/router/src/core/blocklist/transformers.rs  0% smaller
  crates/router/src/core/customers.rs  0% smaller
  crates/router/src/core/payment_methods/utils.rs  0% smaller
  crates/router/src/core/payments/routing.rs  0% smaller
  crates/router/src/core/routing/helpers.rs  0% smaller
  crates/router/src/core/webhooks/utils.rs  0% smaller

@Chethan-rao Chethan-rao linked an issue Jan 10, 2025 that may be closed by this pull request
chore: address Rust 1.84.0 clippy lints #7020
Closed
SanchithHegde
SanchithHegde previously approved these changes Jan 10, 2025
View reviewed changes
apoorvdixit88
apoorvdixit88 previously approved these changes Jan 10, 2025
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Jan 10, 2025
View reviewed changes
AkshayaFoiger
AkshayaFoiger previously approved these changes Jan 10, 2025
View reviewed changes
swangi-kumari
swangi-kumari previously approved these changes Jan 10, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 4664d4b Jan 15, 2025
17 of 19 checks passed
@likhinbopanna likhinbopanna deleted the rust_clippy_1.84.0 branch January 15, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@apoorvdixit88 apoorvdixit88 apoorvdixit88 approved these changes

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Chethan-rao Chethan-rao

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: address Rust 1.84.0 clippy lints
8 participants
@Chethan-rao @SanchithHegde @Narayanbhat166 @prajjwalkumar17 @apoorvdixit88 @swangi-kumari @AkshayaFoiger @likhinbopanna