Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a loading layout in the app #70

Open
justdvnsh opened this issue Oct 10, 2021 · 0 comments
Open

Add a loading layout in the app #70

justdvnsh opened this issue Oct 10, 2021 · 0 comments
Labels
feature-request Label to put if requesting a new feature hacktoberfest Issues to solve if participating in hacktoberfest help wanted Extra attention is needed P1 Priority Task - 1

Comments

@justdvnsh
Copy link
Owner

Currently there is no loading visual feedback in the app. The user is not able to know if the data is being loaded. We need a new common loading layout in the app which we can include in any layout and it should work just fine. Try adding the layout based on live data, which would be controlled from the Common View Model. Currently, the navigation is being controller from the CommonViewModel. Similarly we can add a new live data which tells either the page is being loaded or not and controlled from the commonViewModel iteself. Remember to make it an Event, like

private val _loadingLiveData = MutableLiveData<Event(Boolean)>()

similar to the navigation live data.

@justdvnsh justdvnsh added help wanted Extra attention is needed hacktoberfest Issues to solve if participating in hacktoberfest feature-request Label to put if requesting a new feature P1 Priority Task - 1 labels Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Label to put if requesting a new feature hacktoberfest Issues to solve if participating in hacktoberfest help wanted Extra attention is needed P1 Priority Task - 1
Projects
None yet
Development

No branches or pull requests

1 participant