Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: redefine serial buffer constants in sketch #2

Open
scruss opened this issue Nov 27, 2019 · 0 comments
Open

suggestion: redefine serial buffer constants in sketch #2

scruss opened this issue Nov 27, 2019 · 0 comments

Comments

@scruss
Copy link

scruss commented Nov 27, 2019

Hi - thanks for making and documenting this project!

Rather than editing the Arduino system header HardwareSerial.h, maybe put the revised values in the code itself:

#define SERIAL_TX_BUFFER_SIZE 256
#define SERIAL_RX_BUFFER_SIZE 256

While this does generate a couple of warnings like this one:

 … /serial2ti83/serial2ti83.ino:13:0: warning: "SERIAL_TX_BUFFER_SIZE" redefined
 #define SERIAL_TX_BUFFER_SIZE 256
 
In file included from  … /hardware/arduino/avr/cores/arduino/Arduino.h:232:0,
                 from sketch/serial2ti83.ino.cpp:1:
 … /hardware/arduino/avr/cores/arduino/HardwareSerial.h:46:0: note: this is the location of the previous definition
 #define SERIAL_TX_BUFFER_SIZE 64

it does appear to redefine the buffer sizes properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant