Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kubernetes 1.31 #315

Closed
sambhav opened this issue Aug 20, 2024 · 5 comments · Fixed by #316
Closed

Support for Kubernetes 1.31 #315

sambhav opened this issue Aug 20, 2024 · 5 comments · Fixed by #316

Comments

@sambhav
Copy link
Contributor

sambhav commented Aug 20, 2024

Kubernetes 1.31 has an advanced caching layer https://kubernetes.io/blog/2024/08/15/consistent-read-from-cache-beta/

This requires certain features to be implemented by etcd, specifically https://etcd.io/docs/v3.5/dev-guide/interacting_v3/#watch-progress

Creating this issue to check whether kine is compatible with this feature or not.

@sambhav
Copy link
Contributor Author

sambhav commented Aug 20, 2024

Is #268 enough? Has there been any test with kine around this?

@brandond
Copy link
Member

It works as far as I know. I haven't tested with v1.31, but I did enable the FeatureGate on previous releases on Kubernetes (1.29 and 1.30 IIRC) and it worked fine.

Let me know if you run into any problems and we can reopen. Otherwise I consider it working.

@sambhav
Copy link
Contributor Author

sambhav commented Aug 21, 2024

I am seeing the following -

E0821 11:28:55.647162       1 feature_support_checker.go:165] "Failed to parse etcd version" err="could not parse \"\" as version" version=""
I0821 11:28:55.647183       1 feature_support_checker.go:133] RequestWatchProgress feature is not supported by "https://kine.qa-system.svc.cluster.local:2379" endpoint

The above is with kine 0.11.12 and Kubernetes 1.31.0. The api-server we are using is from registry.k8s.io/kube-apiserver-amd64

@sambhav
Copy link
Contributor Author

sambhav commented Aug 21, 2024

@brandond can we re-open this issue?

@brandond
Copy link
Member

Oh, that's new. Previously releases of Kubernetes did not check the server version so we have always left it empty. I guess they added that as part of promoting the FeatureGate to on by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants