Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

support binaryData for persistence.* of type configMap #129

Open
morremeyer opened this issue Feb 16, 2022 · 2 comments
Open

support binaryData for persistence.* of type configMap #129

morremeyer opened this issue Feb 16, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@morremeyer
Copy link

Details

Helm chart name: common

Describe the solution you'd like: To add binary data to a ConfigMap, there is the the binaryData key. To include e.g. assets in homer without needing to deploy extra resources manually, support for the binaryData key would be helpful.

@morremeyer morremeyer added the enhancement New feature or request label Feb 16, 2022
@bjw-s
Copy link
Contributor

bjw-s commented Feb 21, 2022

If I understand you correctly, you want to store the contents for binaryData in your values.yaml file?

I don't think that is something that we want to support. That would make the content of your values.yaml pretty unreadable. You can of course always store the data in a sidecar configmap file and mount that using the existing persistence options.

@morremeyer
Copy link
Author

Yes, you understood me correctly.

I'd use this with multiple values files, splitting out the binaryData ones to not clutter the others.

Storing it in a sidecar ConfigMap is essentially what I'm doing now, just that I need to deploy an extra resource via some other management method. I want to avoid that as it adds complexity.

Readability of configuration on the other hand is both subjective and manageable by splitting configuration in files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants