This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Meaningful Exceptions #43

Open

3 of 4 tasks

k911 opened this issue Apr 6, 2019 · 0 comments

Labels

good first issue help wanted kind/cleanup priority/important

Owner

k911 commented Apr 6, 2019 •

edited

Loading

Create custom exceptions instead of throwing general ones.

~~PidFileExeception (SwooleServerStart)~~ (feat: Add meaningful exceptions #46)
~~SwooleServerNotRunningExecption (HttpServer)~~ (feat: Add meaningful exceptions #46)
~~ConnectionFailedExecption (HttpClient)~~ (feat: Add meaningful exceptions #46)
Test exceptions added in feat: Add meaningful exceptions #46 (see: https://codecov.io/gh/k911/swoole-bundle for untested places)

k911 added help wanted good first issue kind/cleanup priority/critical labels

fjogeleit mentioned this issue

feat: Add meaningful exceptions #46

Merged

k911 added priority/important and removed priority/critical labels

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.