Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assert code? #118

Open
toshi0383 opened this issue May 18, 2020 · 0 comments
Open

Remove assert code? #118

toshi0383 opened this issue May 18, 2020 · 0 comments

Comments

@toshi0383
Copy link

Hi useful library!

Issue

I use 1.5.4 (via CocoaPods) and sometimes have crash on assert.
I don't want this behavior as it works fine without these assertion, so re-installed via Carthage so assert is always disabled in Release build.

Proposal

Can we remove these assertions?
We might want to ensure these conditions by writing tests or using custom build flags... etc, not affecting in customer(developers) side.
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant