Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] lib file name conflict, maybe re-organize the structure? #18

Closed
robertlzj opened this issue May 21, 2022 · 1 comment
Closed

Comments

@robertlzj
Copy link

Hi, I'm not been guided for how to import this runtime library.
I found namespace conflict, especially class, enum etc, if I copy them to my 'lualibs' directly.

For class, enum, string_stream, string_decode and kaitaistruct all in the same folder level.
And only kaitaistruct is exposed as interface I think.

So, I thought to organize based on kaitaistruct is nice.

  • kaitaistruct.lua
  • "kaitaistruct" directory
    • class.lua
    • enum.lua
    • string_stream.lua
    • string_decode.lua

And require'kaitaistruct.class', require'kaitaistruct.enum', require'kaitaistruct.string_stream', require'kaitaistruct.string_decode' internal.

@generalmimon
Copy link
Member

generalmimon commented May 21, 2022

Duplicate of #11

Please continue the discussion there so we don't have multiple open issues for the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants