Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolute path omission in clean_pid_file() function #7

Open
SomebodyLikeEveryBody opened this issue Feb 1, 2020 · 2 comments
Open

Comments

@SomebodyLikeEveryBody
Copy link
Contributor

For information (minor thing), in the ambient_sound neuron, the modification of the pid.txt file works only if we use the absolute path of the file. This absolute path is used everywhere except in clean_pid_file() function. It doesn't matter for the operation but it lets the last used pid in the file.

It just need to change the 277 and 278 lines:

        try:
            with open(pid_file_path, "w") as file_open:

with

        absolute_pid_file_path = SoundDatabase.get_neuron_path() + os.sep + pid_file_path
        try:
            with open(absolute_pid_file_path, "w") as file_open:
@LaMonF
Copy link
Member

LaMonF commented Feb 2, 2020

Hi @SomebodyLikeEveryBody Thanks for the feedback.
Can you please open a Pull request with your suggestion on the code changes ? Cheers

@SomebodyLikeEveryBody
Copy link
Contributor Author

@LaMonF
Thanks ! It's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants