Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /metrics endpoint #19

Open
onedr0p opened this issue May 25, 2024 · 9 comments
Open

Improve /metrics endpoint #19

onedr0p opened this issue May 25, 2024 · 9 comments

Comments

@onedr0p
Copy link
Contributor

onedr0p commented May 25, 2024

Not sure what to gather but maybe there some ideas with the other webhook providers.

@jimmy-ungerman
Copy link

@onedr0p
Copy link
Contributor Author

onedr0p commented May 26, 2024

I implemented the structure, but it needs some work to add more metrics. It only has Go defaults being exported.

@onedr0p onedr0p changed the title Implement /metrics endpoint Improve /metrics endpoint May 26, 2024
@kashalls
Copy link
Owner

I implemented the structure, but it needs some work to add more metrics. It only has Go defaults being exported.

Probably unifi 404's 405's 401's etc... Records updated

@kashalls
Copy link
Owner

I'll eventually pick this issue up, but I am unsure how to handle metrics. Might wait for a day to have onedr0p help me with this.

@jimmy-ungerman
Copy link

I'm going to start working on this but want to get a feel for the metrics that we want to capture.

My thought is:

  • Records created by the webhook
  • Number of requests grouped by status code
  • Response time? Not sure if this one is completely necessary

@kashalls
Copy link
Owner

* Records created by the webhook
* Number of requests grouped by status code
* Response time? Not sure if this one is completely necessary

These should be good enough to get started.

Some fun ones would be records created / updated / removed by the webhook.
How often records are being changed?

@kashalls
Copy link
Owner

Hey @jimmy-ungerman, I wanted to check in and see how it was progressing. Do you need any help?

@jimmy-ungerman
Copy link

Oh we're trying lol. I'm away for the holiday weekend, but plan on looking even more next week. First time trying to implement metrics lol

@jimmy-ungerman
Copy link

Going to test this commit here for a basic "records count" metric jimmy-ungerman@00e344c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants