-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve /metrics
endpoint
#19
Comments
Looks like a good starting point https://github.com/stackitcloud/external-dns-stackit-webhook/tree/main/pkg/metrics |
I implemented the structure, but it needs some work to add more metrics. It only has Go defaults being exported. |
Probably unifi 404's 405's 401's etc... Records updated |
I'll eventually pick this issue up, but I am unsure how to handle metrics. Might wait for a day to have onedr0p help me with this. |
I'm going to start working on this but want to get a feel for the metrics that we want to capture. My thought is:
|
These should be good enough to get started. Some fun ones would be records created / updated / removed by the webhook. |
Hey @jimmy-ungerman, I wanted to check in and see how it was progressing. Do you need any help? |
Oh we're trying lol. I'm away for the holiday weekend, but plan on looking even more next week. First time trying to implement metrics lol |
Going to test this commit here for a basic "records count" metric jimmy-ungerman@00e344c |
Not sure what to gather but maybe there some ideas with the other webhook providers.
The text was updated successfully, but these errors were encountered: