Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day frame selection #9

Open
Ralf-Th opened this issue Nov 2, 2024 · 8 comments
Open

Day frame selection #9

Ralf-Th opened this issue Nov 2, 2024 · 8 comments

Comments

@Ralf-Th
Copy link

Ralf-Th commented Nov 2, 2024

you have a very cool intergration.
thank you for that.
Wozld it be possible to select a day frame (from day to day) instrad of countdown timer?

@Darkdragon14
Copy link

Hey,
I am currently working on it. I agree with you that this is a good idea.
You can find a fisrt draft (it works) on this branch but I need to add some change like using jwt with RSA encoding or displaying the token information.
If my first PR#8 is validated, I will suggest this solution in another PR.
Maybe another thing to do is to create 2 projects. One for the integration and one for dashboard. It will be more compliant with HACS. But for this, we need an approval from the author of this repo ^^

(For using my branch, I think the best solution is to replace your current files by elements in my branch and for the js file create a gz file. If you want to explain more don't hesitate to ask me :))

Have a nice day !

@kcsoft
Copy link
Owner

kcsoft commented Nov 11, 2024

implemented, please reinstall the component to apply the updates

@kcsoft kcsoft closed this as completed Nov 11, 2024
@Darkdragon14
Copy link

It's not the same feature. The demand is to have a start date and an end date. Your implementation is just a end date

@kcsoft
Copy link
Owner

kcsoft commented Nov 11, 2024

HA uses PyJWT for storing jw tokens and it doesn't allow to set a starting date. So it isn't possible to set a start date, only an end date.

@Ralf-Th
Copy link
Author

Ralf-Th commented Nov 11, 2024

but is it not possible to create the token with a kind of automation on the desired starting time and then only with the desired end-time?

@Darkdragon14
Copy link

Darkdragon14 commented Nov 11, 2024

It's possible. For this you need a database with start-date and end date just go to see my branch how I hack this problem https://github.com/Darkdragon14/ha-guest-mode/tree/feature/date-range-mode

@kcsoft kcsoft reopened this Nov 13, 2024
@kcsoft
Copy link
Owner

kcsoft commented Nov 13, 2024

I reopened the issue and I will investigate a bit on my side too.
@Darkdragon14 nice one! I would prefer to allow HA to manage tokens and not store them.

@Darkdragon14
Copy link

I understand, but I don't see another solution to do this. But if you find something, I am curious to see the result ^^

Another thing, maybe you have the solution. How can we load elements of HA frontend? Like ha-date-range-picker without use history or logbook pages ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants