Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Max Stack Size #176

Closed
b-j-roberts opened this issue Aug 27, 2024 · 2 comments
Closed

[feat] Max Stack Size #176

b-j-roberts opened this issue Aug 27, 2024 · 2 comments
Assignees
@mubarak23
Labels
enhancement New feature or request

Comments

@b-j-roberts
Copy link
Contributor

Bitcoin Script has a max stack size of 1000 items. We will need to implement checks into the engine to ensure this stack size is never exceeded.

I'd recommend following the design of btcd for stack size, since our engine design is so similar.

References

btcd stack size
Shinigami engine
@b-j-roberts b-j-roberts added the enhancement New feature or request label Aug 27, 2024
@b-j-roberts
Copy link
Contributor Author

@mubarak23 Please comment here if you'd like to take on this issue. thank you!

@mubarak23
Copy link
Contributor

am here , yes

@mubarak23 mubarak23 mentioned this issue Aug 28, 2024
Merged
2 tasks
b-j-roberts added a commit that referenced this issue Aug 29, 2024
@mubarak23 @b-j-roberts
check for stack size before executing the opcode (#182)
1ca6ab7 
- [x] issue #176 
- [x] follows contribution
[guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md)

---------

Co-authored-by: Brandon Roberts <[email protected]>
@b-j-roberts b-j-roberts mentioned this issue Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mubarak23 mubarak23

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mubarak23 @b-j-roberts