Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: while I < data.len to let data_len = data.len() #218

Closed
wants to merge 2 commits into from
Closed

fix: while I < data.len to let data_len = data.len() #218

wants to merge 2 commits into from

Conversation

Mystic-Nayy
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Sep 14, 2024

Someone is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@Mystic-Nayy Mystic-Nayy changed the title feat: code optimization fix: while I < data.len to let daya_len = data.len() Sep 17, 2024
@Mystic-Nayy Mystic-Nayy changed the title fix: while I < data.len to let daya_len = data.len() fix: while I < data.len to let data_len = data.len() Sep 17, 2024
b-j-roberts
b-j-roberts requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR. There are a lot of spots in the shinigami cairo that code need this same change done. Could you optimize all the loops that have this pattern?

@Mystic-Nayy
Copy link
Contributor Author

Hey, thanks for the PR. There are a lot of spots in the shinigami cairo that code need this same change done. Could you optimize all the loops that have this pattern?

@b-j-roberts I've optimized all the loops in that pattern

@Mystic-Nayy Mystic-Nayy closed this by deleting the head repository Sep 26, 2024
@Mystic-Nayy Mystic-Nayy mentioned this pull request Sep 26, 2024
Merged
b-j-roberts added a commit that referenced this pull request Oct 4, 2024
@Mystic-Nayy @b-j-roberts
refac: refactor while I < data.len to let data_len = data.len() (#234)
e462096 
Resolves #218

---------

Co-authored-by: Gift-Naomi <emmanuelgiftnaomi.com>
Co-authored-by: Brandon Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dev] [optimization] 'while i < data.len()' to 'let data_len = data.len()'
2 participants
@Mystic-Nayy @b-j-roberts