Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] [bitcoin-core test] ScriptSig: '0x27 0x3024021077777777777777777777777777777777020a7777777777777777777777777777777701' -- ScriptPubKey: '0 CHECKSIG NOT' #211

Closed
b-j-roberts opened this issue Sep 12, 2024 · 7 comments · Fixed by #223
Closed

[bug] [bitcoin-core test] ScriptSig: '0x27 0x3024021077777777777777777777777777777777020a7777777777777777777777777777777701' -- ScriptPubKey: '0 CHECKSIG NOT' #211

b-j-roberts opened this issue Sep 12, 2024 · 7 comments · Fixed by #223
Labels
bug Something isn't working

Comments

@b-j-roberts
Copy link
Contributor

Issue

The following bitcoin-core test is failing to give the correct result :

ScriptSig: '0x27 0x3024021077777777777777777777777777777777020a7777777777777777777777777777777701' -- ScriptPubKey: '0 CHECKSIG NOT'

This code should be passing, but is panicking when executing.

Replicate

To replicate the issue you can use the latest main branch with the following command:

scarb cairo-run '[[85638222473728638769160410210893464261263086061422684165462972715402475319,97557673223841770041305211021412912560163447137005097938746121282641147703],5288612062596008609236648564283419927782315402045370417,23,[],976111785041138328458856412106580,14,[],0,0]'

This comment might help some with how to debug : #192 (comment)
@b-j-roberts b-j-roberts added the bug Something isn't working label Sep 12, 2024
@ShantelPeters
Copy link
Contributor

ShantelPeters commented Sep 12, 2024 •
edited
Loading

@b-j-roberts can I please work on this ?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 12, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@mubarak23
Copy link
Contributor

If this is panicking the opcode is expecting a different value other than what was pass, a quick logs along the execution path will show what is happening,

@b-j-roberts kindly assigned

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 12, 2024

@b-j-roberts i would love to work on this issue ser

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 12, 2024

Hey @Jemiiah!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@b-j-roberts
Copy link
Contributor Author

b-j-roberts commented Sep 12, 2024 •
edited
Loading

@b-j-roberts can I please work on this ?

Yes, I can assign you. Thank you. Let me know if you have any questions, I will check-in in a couple days on progress. @ShantelPeters

@b-j-roberts
Copy link
Contributor Author

@ShantelPeters Have you been able to get any progress debugging this yet?

@dlaciport dlaciport mentioned this issue Sep 18, 2024
Merged
4 tasks
b-j-roberts added a commit that referenced this issue Oct 4, 2024
@dlaciport @b-j-roberts
fix: fix opchecksig bug (#223)
196aa5c 
<!-- enter the gh issue after hash -->

- [x] fixes #211 
- [x] fixes #212 
- [x] follows contribution
[guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md)
- [ ] code change includes tests


![image](https://github.com/user-attachments/assets/f3bc58f5-5b1b-4f12-bebe-27eaed34313c)


![image](https://github.com/user-attachments/assets/3b787881-2986-4140-84df-78b79c737665)



<!-- PR description below -->

---------

Co-authored-by: Brandon Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix opchecksig bug dlaciport/shinigami
4 participants
@mubarak23 @b-j-roberts @Jemiiah @ShantelPeters