Fix Script sig push only with OP_DATA_X [Bug] #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Sep 17, 2024
jsandinoDev
changed the title
b-j-roberts
approved these changes
Sep 18, 2024
j1mbo64
pushed a commit
to j1mbo64/shinigami
that referenced
this pull request
Sep 18, 2024
) <!-- enter the gh issue after hash --> - [✅] issue keep-starknet-strange#213 - [✅] follows contribution [guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md) - [✅] code change includes tests <!-- PR description below --> Refactor the implementation of the **is_push_only** function. Closes keep-starknet-strange#213 Closes keep-starknet-strange#216 For the keep-starknet-strange#214 && keep-starknet-strange#215 I think that the problem might be in the <img width="702" alt="Screenshot 2024-09-16 at 10 58 59 PM" src="https://github.com/user-attachments/assets/73ef5d77-5965-478c-9543-3826c22d41b0"> --------- Co-authored-by: [email protected] <jsandinoDevjsandinoDevjsandinoDev> Co-authored-by: Brandon Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the implementation of the is_push_only function.
Closes #213
Closes #216
For the #214 && #215 I think that the problem might be in the