Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add support for OP_NOP2 & OP_NOP3 in compiler #228

Closed
b-j-roberts opened this issue Sep 24, 2024 · 7 comments
Closed

[feat] Add support for OP_NOP2 & OP_NOP3 in compiler #228

b-j-roberts opened this issue Sep 24, 2024 · 7 comments
Assignees
@adrianvrj

Comments

@b-j-roberts
Copy link
Contributor

Add the following Opcodes to the compiler & opcodes list :
OP_NOP2 -> 0xb1 ( Same as Opcode::OP_CHECKLOCKTIMEVERIFY )
OP_NOP3 -> 0xb2 ( Same as Opcode::OP_CHECKSEQUENCEVERIFY )

References

opcodes
compiler
@adrianvrj
Copy link
Contributor

@b-j-roberts can I work on this one?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 24, 2024

Hey @adrianvrj!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@ShantelPeters
Copy link
Contributor

Please can I be assigned to this issue ?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 24, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@Iwueseiter
Copy link
Contributor

@b-j-roberts can I work on this?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Iwueseiter!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@b-j-roberts
Copy link
Contributor Author

b-j-roberts commented Sep 24, 2024 •
edited
Loading

@b-j-roberts can I work on this one?

Sure, I'll assign you. Thanks @adrianvrj

@adrianvrj adrianvrj mentioned this issue Oct 4, 2024
Merged
3 tasks
b-j-roberts pushed a commit that referenced this issue Oct 4, 2024
@adrianvrj
[feat] mapped OPNOP2 and OPNOP3 (#244)
e4aaa77 
<!-- enter the gh issue after hash -->

- [x] issue #228
- [x] follows contribution
[guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md)
- [ ] code change includes tests

<!-- PR description below -->

This PR will map the OP_NOP2 and OP_NOP3 in the compiler and add them to
the OP codes list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianvrj adrianvrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@b-j-roberts @adrianvrj @Iwueseiter @ShantelPeters