Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why Windows tests fail #66

Open
keithamus opened this issue Dec 15, 2024 · 1 comment · Fixed by #74
Open

Investigate why Windows tests fail #66

keithamus opened this issue Dec 15, 2024 · 1 comment · Fixed by #74

Comments

@keithamus
Copy link
Owner

Looks like windows tests are failing: https://github.com/keithamus/hdx/actions/runs/12334550029/job/34424890161

Seems like offsets are a few characters off in the snapshot tests. Is this CRLF line ending? Can we avoid this somehow?
@keithamus keithamus mentioned this issue Dec 15, 2024
Closed
maraisr added a commit to maraisr/hdx that referenced this issue Dec 17, 2024
@maraisr
fix: we cannot pprof in windows
ce6bf5c 
closes: keithamus#66
@maraisr maraisr mentioned this issue Dec 17, 2024
Merged
@keithamus keithamus mentioned this issue Dec 17, 2024
Merged
@keithamus
Copy link
Owner Author

Windows still failing.

@keithamus keithamus reopened this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: we cannot pprof in windows maraisr/hdx
attempt to fix windows tests keithamus/hdx
1 participant
@keithamus