Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Stream Support? #16

Closed
CodeMan99 opened this issue Feb 6, 2018 · 7 comments
Closed

No Stream Support? #16

CodeMan99 opened this issue Feb 6, 2018 · 7 comments

Comments

@CodeMan99
Copy link

CodeMan99 commented Feb 6, 2018

Of the default decompress plugins, this seems to be the only one that doesn't seem to support streamed input.

Is there a particular reason why streaming is not supported for unzip? There is already a dependency on get-stream, so it seems reasonable to just put that in front of the yauzl call.

@kevva
Copy link
Owner

kevva commented Feb 7, 2018

Yes, I've explained why in kevva/decompress#29 (comment). Until we've a better alternative to yauzl, I think we're stuck with the Promise API.

@kevva kevva closed this as completed Feb 7, 2018
@CodeMan99
Copy link
Author

Ok. So just for the sake of future readers. You are saying that you agree with the author of yauzl and that the library shouldn't buffer the stream contents?

@kevva
Copy link
Owner

kevva commented Feb 8, 2018

I'd like for this module to support streams, but since yauzl doesn't, and since it's the best alternative out there currently, I don't see how we can accomplish it right now.

@CodeMan99
Copy link
Author

CodeMan99 commented Feb 8, 2018

I don't see how we can accomplish it right now.

You mean without using getStream.buffer?

I mean, if you are ok with buffering internally in the plugin, it would be very easy to do.

@kevva
Copy link
Owner

kevva commented Feb 15, 2018

It's not super pure, but sure, we could do it. PR welcome.

@CodeMan99
Copy link
Author

@kevva Closing this again as the PR is now closed.

@kevva
Copy link
Owner

kevva commented Sep 6, 2019

Apparently I changed my mind since. But yeah, not a big fan of supporting it if we're going to buffer it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants