-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Stream Support? #16
Comments
Yes, I've explained why in kevva/decompress#29 (comment). Until we've a better alternative to |
Ok. So just for the sake of future readers. You are saying that you agree with the author of |
I'd like for this module to support streams, but since |
You mean without using I mean, if you are ok with buffering internally in the plugin, it would be very easy to do. |
It's not super pure, but sure, we could do it. PR welcome. |
@kevva Closing this again as the PR is now closed. |
Apparently I changed my mind since. But yeah, not a big fan of supporting it if we're going to buffer it anyway. |
Of the default
decompress
plugins, this seems to be the only one that doesn't seem to support streamed input.Is there a particular reason why streaming is not supported for unzip? There is already a dependency on
get-stream
, so it seems reasonable to just put that in front of theyauzl
call.The text was updated successfully, but these errors were encountered: