JSON Localization doesn't care about the main Language

[ridaamirini]

Hello @kg-bot :)

I saw that the JSON import feature is new #19.

I have noticed a problem now. Although the JSON are considered during the export but the English version is not, because we don't have a en.json because the english translation is the key.

[kg-bot]

Hello @ridaamirini

Yup, and I don't have any idea how could we do that because not everyone's main language is English.

I would love to hear some suggestions if you have them 😄

[ridaamirini]

I have two ideas.

1. We could make it as a value in the laravel-localization.php and the default value will the default language of laravel app

2. We say the default language in laravel is the main language

[kg-bot]

Yup, we could do it like that, but I don't think I'll have time for that today.

[ridaamirini]

Ok i try to PR. I think we need to use the first solution but without any default value from the laravel app config because this is dynamic.

[ridaamirini]

This line of code makes no sense to me.

laravel-localization-to-vue/src/Classes/ExportLocalizations.php

Lines 182 to 186 in 4e019fa

	if (array_key_exists($key, $results)) {
	$results[$key] = $json_strings;
	} else {
	$results[$key] = $json_strings;
	}

[ridaamirini]

@kg-bot i added a PR (#27) for toFlat(). I don't know if we should change the other methods to

[ridaamirini]

@kg-bot I just releazied what is about when we have no json.

Laravel is handling it returning the string back. But with our prefix we will have __JSON__ everytime printed out.

[kg-bot]

When you're calling json translations you must do it with trans.get('__JSON__.Hello world'), it was designed like that.

[ridaamirini]

@kg-bot yeah i understand it's a Lang.js "issue"

[ludo237]

@kg-bot hijacking this issue to let you know that this feature should be documented because it's really a headache to find out by yourself 😆

[ridaamirini]

Note that this issue can also solved on client side like this rmariuzzo/Lang.js#69 (comment)