batchaccession -'donation_date' question

[raecasey]

perhaps the -donation_date argument could be pulled from accession.py as a question in batchaccession.py in the same way you have done for the -donor and -depositor_reference arguments.
so it would ask -
What is the date of Donation? DD/MM/YYY. Not applicable for Reproductions.

we'd enter n/a as usual or reproductions and the donation date for everything else.
screen ireland/bai stuff we'll be entering the date on the object entry register. (we'll need to figure out how we can deal with that - not for this thread i think)

would be good, as with the other questions if 'are you really sure? y/n' is asked again. its really helpful i think and have often been glad of it.

currently batchaccession.py uses date of creation as a default for date of donation and that gets imported into the databse unless it is manually changed.

with this addition, we would cut down on the need to open up and modify the pbcore_csv in libre office; cut down on the possibility of having to make lots of manual changes int eh database and also put date/acquired and date of donation on the top of people's minds, because it can easily slip through the cracks and be taken for granted.

R

[raecasey]

adding further thoughts here that i also added to the updates document. full explanation of the thinking behind this can be found on that document:

The date of donation question on batchaccession.py might look something like this:

What is the date of donation?
1.Date of Creation (for reproductions)
2.Date Received on OE-Register (over-arching deposit agreements)
3.Other

If we enter 1- the script does what it always has done and pulls the date of creation into the date of acquisition field in the epbcore_csv
If we enter 2 - the script pulls the date from the date received column in the oe_csv which has already been fed into the script.
If we enter 3 - the script prints:
Please enter the date of donation DD/MM/YYYY
Are you really sure? Y/N?

[raecasey]

@kieranjol update on this. i ran batchaccession.py on two dcps and the correct donation date (date of object entry) turned up on the pbocre csv.
i can't account for this other than you must have already thought of getting batchaccession.py to pull from the oe register for date of donation?
i'm flummuxed.
in any case, we will still need to add in the -donation_date question to the script so that other donation or deposit agreements can be accommodated.
i'll do some more tests with Yujing next week, but perhaps this means that adding in this question is not as much as a priority as we'd thought. And yujing van move onto dcps whenever she is ready

[kieranjol]

This rings a bell,I must have actioned the date from OE thing based on DCM feedback. I would have to look through commit history to be sure.

…

On Fri, 28 Jun 2019, 17:09 raecasey, ***@***.***> wrote: @kieranjol <https://github.com/kieranjol> update on this. i ran batchaccession.py on two dcps and the correct donation date (date of object entry) turned up on the pbocre csv. i can't account for this other than you must have already thought of getting batchaccession.py to pull from the oe register for date of donation? i'm flummuxed. in any case, we will still need to add in the -donation_date question to the script so that other donation or deposit agreements can be accommodated. i'll do some more tests with Yujing next week, but perhaps this means that adding in this question is not as much as a priority as we'd thought. And yujing van move onto dcps whenever she is ready — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#343?email_source=notifications&email_token=AAITFPU63DAA6XNWGZN6EPDP4YZSTA5CNFSM4H2W77S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2P5MY#issuecomment-506789555>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAITFPSAC7KHGI7P5MQGJIDP4YZSTANCNFSM4H2W77SQ> .

[kieranjol]

I'll have to look through your messages further but it appears that batchaccession has been pulling the date of acquisition from the OE register for close to nine months...
Did you find an instance of it not doing this?

[raecasey]

ah.. - well that's good.
i need to have a look. i had thought that there were times that i hadn't the date filled in on the oe register at the point that i fed it to batchaccession. but maybe i always had.
leave it with me.