Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person ID with leading zeroes #193

Open
robinmaisch opened this issue Nov 27, 2024 · 0 comments
Open

Person ID with leading zeroes #193

robinmaisch opened this issue Nov 27, 2024 · 0 comments

Comments

@robinmaisch
Copy link

A TA remarked that on the official documents by the faculty, his ID has a leading zero, which lead to an exception with the TimeSheetGenerator.
I was able to reproduce the following error message using the ID "0234567":

Invalid numeric value: Leading zeroes not allowed
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 4, column: 14]

I would assume that the leading zero is not required for the time sheet to be correct.
So maybe we can allow for the ID to have a leading zero in the global file, but then—silently or with a message—omit it from the sheet, just to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant