Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases should avoid dynamic non-test-relevant behavior #84

Open
gstuer opened this issue Apr 18, 2020 · 2 comments
Open

Test cases should avoid dynamic non-test-relevant behavior #84

gstuer opened this issue Apr 18, 2020 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@gstuer
Copy link
Contributor

gstuer commented Apr 18, 2020

Test cases should avoid dynamic non-test-relevant behavior
We should change dynamic expressions like LocalDate.now() in tests to static constants in order to improve the reliability of the tests. Dynamic behavior should only be part of a test, if the test is especially built for such a parametrization.

Originally posted by @gstuer in #79
@gstuer gstuer added the enhancement New feature or request label Apr 18, 2020
@larsk21
Copy link
Contributor

larsk21 commented Jul 17, 2020

see PR_DynamicTestBehaviour

I already removed LocalDate.now(). Is there any other unnecessary use of randomness in our tests?

@larsk21 larsk21 added the question Further information is requested label Jul 17, 2020
@larsk21
Copy link
Contributor

larsk21 commented Jul 28, 2020

@gstuer ?

@larsk21 larsk21 mentioned this issue Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unnecessary dynamic test behaviour kit-sdq/TimeSheetGenerator
2 participants
@gstuer @larsk21